Title: [268761] trunk/Tools
Revision
268761
Author
jbed...@apple.com
Date
2020-10-20 14:40:40 -0700 (Tue, 20 Oct 2020)

Log Message

[webkitpy] Use allowlist and blocklist
https://bugs.webkit.org/show_bug.cgi?id=217985
<rdar://problem/70499499>

Reviewed by Aakash Jain.

* Scripts/webkitpy/pylintrc:
* Scripts/webkitpy/style/checkers/cpp.py:
(check_namespace_indentation):
* Scripts/webkitpy/w3c/common.py:
(is_basename_skipped):
* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_gstbuild):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (268760 => 268761)


--- trunk/Tools/ChangeLog	2020-10-20 21:23:53 UTC (rev 268760)
+++ trunk/Tools/ChangeLog	2020-10-20 21:40:40 UTC (rev 268761)
@@ -1,3 +1,19 @@
+2020-10-20  Jonathan Bedard  <jbed...@apple.com>
+
+        [webkitpy] Use allowlist and blocklist
+        https://bugs.webkit.org/show_bug.cgi?id=217985
+        <rdar://problem/70499499>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/pylintrc:
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_namespace_indentation):
+        * Scripts/webkitpy/w3c/common.py:
+        (is_basename_skipped):
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak.setup_gstbuild):
+
 2020-10-20  Aakash Jain  <aakash_j...@apple.com>
 
         Make report-non-inclusive-language ignore autoinstalled directories and certain file types

Modified: trunk/Tools/Scripts/webkitpy/pylintrc (268760 => 268761)


--- trunk/Tools/Scripts/webkitpy/pylintrc	2020-10-20 21:23:53 UTC (rev 268760)
+++ trunk/Tools/Scripts/webkitpy/pylintrc	2020-10-20 21:40:40 UTC (rev 268761)
@@ -38,7 +38,7 @@
 # Profiled execution.
 profile=""
 
-# Add files or directories to the blacklist. They should be base names, not
+# Add files or directories to the blocklist. They should be base names, not
 # paths.
 ignore=CVS
 

Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (268760 => 268761)


--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2020-10-20 21:23:53 UTC (rev 268760)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2020-10-20 21:40:40 UTC (rev 268761)
@@ -2484,7 +2484,7 @@
             break
 
 
-# Enum declaration whitelist
+# Enum declaration allowlist
 _ALLOW_ALL_UPPERCASE_ENUM = ['JSTokenType']
 
 

Modified: trunk/Tools/Scripts/webkitpy/w3c/common.py (268760 => 268761)


--- trunk/Tools/Scripts/webkitpy/w3c/common.py	2020-10-20 21:23:53 UTC (rev 268760)
+++ trunk/Tools/Scripts/webkitpy/w3c/common.py	2020-10-20 21:40:40 UTC (rev 268761)
@@ -79,12 +79,12 @@
     skipped basenames are never imported or exported.
     """
     assert '/' not in basename
-    blacklist = [
+    blocklist = [
         'MANIFEST.json',    # MANIFEST.json is automatically regenerated.
         'OWNERS',           # https://crbug.com/584660 https://crbug.com/702283
         'reftest.list',     # https://crbug.com/582838
     ]
-    return (basename in blacklist
+    return (basename in blocklist
             or is_testharness_baseline(basename)
             or basename.startswith('.'))
 

Modified: trunk/Tools/flatpak/flatpakutils.py (268760 => 268761)


--- trunk/Tools/flatpak/flatpakutils.py	2020-10-20 21:23:53 UTC (rev 268760)
+++ trunk/Tools/flatpak/flatpakutils.py	2020-10-20 21:40:40 UTC (rev 268761)
@@ -615,13 +615,13 @@
 
         command = [os.path.join(gst_dir, 'gst-env.py'), '--builddir', gst_builddir, '--srcdir', gst_dir, "--only-environment"]
         gst_env = run_sanitized(command, gather_output=True)
-        whitelist = ("LD_LIBRARY_PATH", "PATH", "PKG_CONFIG_PATH")
+        allowlist = ("LD_LIBRARY_PATH", "PATH", "PKG_CONFIG_PATH")
         nopathlist = ("GST_DEBUG", "GST_VERSION", "GST_ENV")
         env = []
         for line in [line for line in gst_env.splitlines() if not line.startswith("export")]:
             tokens = line.split("=")
             var_name, contents = tokens[0], "=".join(tokens[1:])
-            if not var_name.startswith("GST_") and var_name not in whitelist:
+            if not var_name.startswith("GST_") and var_name not in allowlist:
                 continue
             if var_name not in nopathlist:
                 new_contents = ':'.join([self.host_path_to_sandbox_path(p) for p in contents.split(":")])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to