Title: [268786] trunk/Source/WebInspectorUI
- Revision
- 268786
- Author
- drou...@apple.com
- Date
- 2020-10-20 23:25:38 -0700 (Tue, 20 Oct 2020)
Log Message
Web Inspector: REGRESSION(r266074): Uncaught Exception: undefined is not an object (evaluating 'this._allListenersBreakpoint.disabled')
https://bugs.webkit.org/show_bug.cgi?id=217992
Reviewed by Joseph Pecoraro.
r266074 changed it such that `_allListenersBreakpoint` doesn't always exist, so check that
it exists before getting a property from it.
* UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype.listenerBreakpointForEventName):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (268785 => 268786)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-21 06:09:16 UTC (rev 268785)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-21 06:25:38 UTC (rev 268786)
@@ -1,3 +1,16 @@
+2020-10-20 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: REGRESSION(r266074): Uncaught Exception: undefined is not an object (evaluating 'this._allListenersBreakpoint.disabled')
+ https://bugs.webkit.org/show_bug.cgi?id=217992
+
+ Reviewed by Joseph Pecoraro.
+
+ r266074 changed it such that `_allListenersBreakpoint` doesn't always exist, so check that
+ it exists before getting a property from it.
+
+ * UserInterface/Controllers/DOMDebuggerManager.js:
+ (WI.DOMDebuggerManager.prototype.listenerBreakpointForEventName):
+
2020-10-20 Nikita Vasilyev <nvasil...@apple.com>
REGRESSION(r268691): Web Inspector: WI.Sidebar.Event.CollapsedStateChanged is undefined
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js (268785 => 268786)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2020-10-21 06:09:16 UTC (rev 268785)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js 2020-10-21 06:25:38 UTC (rev 268786)
@@ -354,7 +354,7 @@
listenerBreakpointForEventName(eventName)
{
- if (DOMDebuggerManager.supportsAllListenersBreakpoint() && !this._allListenersBreakpoint.disabled)
+ if (DOMDebuggerManager.supportsAllListenersBreakpoint() && this._allListenersBreakpoint && !this._allListenersBreakpoint.disabled)
return this._allListenersBreakpoint;
return this._listenerBreakpoints.find((breakpoint) => breakpoint.eventName === eventName) || null;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
