Title: [268807] trunk/LayoutTests
- Revision
- 268807
- Author
- grao...@webkit.org
- Date
- 2020-10-21 11:07:34 -0700 (Wed, 21 Oct 2020)
Log Message
[WK1] webanimations/accelerated-overlapping-transform-animations.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=217997
<rdar://problem/70505533>
Reviewed by Dean Jackson.
On WK1 UIHelper.ensureStablePresentationUpdate() does not guarantee frames have elapsed so we
wait a couple of animation frames in that configuration to ensure an accelerated animation has
been applied.
* platform/mac-wk1/TestExpectations:
* webanimations/accelerated-overlapping-transform-animations.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (268806 => 268807)
--- trunk/LayoutTests/ChangeLog 2020-10-21 18:07:09 UTC (rev 268806)
+++ trunk/LayoutTests/ChangeLog 2020-10-21 18:07:34 UTC (rev 268807)
@@ -1,3 +1,18 @@
+2020-10-21 Antoine Quint <grao...@webkit.org>
+
+ [WK1] webanimations/accelerated-overlapping-transform-animations.html is a failure
+ https://bugs.webkit.org/show_bug.cgi?id=217997
+ <rdar://problem/70505533>
+
+ Reviewed by Dean Jackson.
+
+ On WK1 UIHelper.ensureStablePresentationUpdate() does not guarantee frames have elapsed so we
+ wait a couple of animation frames in that configuration to ensure an accelerated animation has
+ been applied.
+
+ * platform/mac-wk1/TestExpectations:
+ * webanimations/accelerated-overlapping-transform-animations.html:
+
2020-10-21 Youenn Fablet <you...@apple.com>
WebRTC VP9 Decoder should be able to use VTB
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (268806 => 268807)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-10-21 18:07:09 UTC (rev 268806)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-10-21 18:07:34 UTC (rev 268807)
@@ -1198,5 +1198,3 @@
webkit.org/b/217761 [ Mojave+ Debug ] webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Pass Crash ]
webkit.org/b/217934 inspector/debugger/breakpoint-resolve-when-script-added.html [ Skip ]
-
-webkit.org/b/217997 webanimations/accelerated-overlapping-transform-animations.html [ Pass Failure ]
Modified: trunk/LayoutTests/webanimations/accelerated-overlapping-transform-animations.html (268806 => 268807)
--- trunk/LayoutTests/webanimations/accelerated-overlapping-transform-animations.html 2020-10-21 18:07:09 UTC (rev 268806)
+++ trunk/LayoutTests/webanimations/accelerated-overlapping-transform-animations.html 2020-10-21 18:07:34 UTC (rev 268807)
@@ -14,6 +14,15 @@
<script src=""
<script>
+const waitForAnimationCommit = async (animation) => {
+ await animation.ready;
+ if (!UIHelper.isWebKit2()) {
+ await UIHelper.renderingUpdate();
+ await UIHelper.renderingUpdate();
+ } else
+ await UIHelper.ensureStablePresentationUpdate()
+}
+
(async () => {
if (window.testRunner)
testRunner.waitUntilDone();
@@ -23,20 +32,11 @@
// Make the animations last a whole minute so they don't end while the test is running.
const duration = 60 * 1000;
- // Start a first stationary "transform" animation.
- const firstAnimation = target.animate({ transform: ["translateX(100px)", "translateX(100px)"] }, duration);
+ // Start a first stationary "transform" animation and wait until it has been applied before starting
+ // a second stationary "transform" animation which should replace the first one.
+ await waitForAnimationCommit(target.animate({ transform: ["translateX(100px)", "translateX(100px)"] }, duration));
+ await waitForAnimationCommit(target.animate({ transform: ["translateX(200px)", "translateX(200px)"] }, duration));
- // Wait until this first animation has been applied.
- await firstAnimation.ready;
- await UIHelper.ensureStablePresentationUpdate();
-
- // Now start a second stationary "transform" animation, which should replace the previous animation.
- const secondAnimation = target.animate({ transform: ["translateX(200px)", "translateX(200px)"] }, duration);
-
- // Wait until this second animation has been applied.
- await secondAnimation.ready;
- await UIHelper.ensureStablePresentationUpdate();
-
if (window.testRunner)
testRunner.notifyDone();
})();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
