Title: [268933] trunk/LayoutTests
Revision
268933
Author
simon.fra...@apple.com
Date
2020-10-23 11:49:32 -0700 (Fri, 23 Oct 2020)

Log Message

[ macOS wk2 ] fast/scrolling/latching/latched-scroll-remove-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216059
<rdar://problem/68177922>

Reviewed by Sam Weinig.

Deflake the test by not using a 16ms timeout, and remove the expectation.

* fast/scrolling/latching/latched-scroll-remove-iframe.html:
* platform/mac-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (268932 => 268933)


--- trunk/LayoutTests/ChangeLog	2020-10-23 18:35:44 UTC (rev 268932)
+++ trunk/LayoutTests/ChangeLog	2020-10-23 18:49:32 UTC (rev 268933)
@@ -1,3 +1,16 @@
+2020-10-23  Simon Fraser  <simon.fra...@apple.com>
+
+        [ macOS wk2 ] fast/scrolling/latching/latched-scroll-remove-iframe.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=216059
+        <rdar://problem/68177922>
+
+        Reviewed by Sam Weinig.
+        
+        Deflake the test by not using a 16ms timeout, and remove the expectation.
+
+        * fast/scrolling/latching/latched-scroll-remove-iframe.html:
+        * platform/mac-wk2/TestExpectations:
+
 2020-10-23  Antoine Quint  <grao...@webkit.org>
 
         REGRESSION(r268615): certain animations break when moving from one to display to another or resizing the window

Modified: trunk/LayoutTests/fast/scrolling/latching/latched-scroll-remove-iframe.html (268932 => 268933)


--- trunk/LayoutTests/fast/scrolling/latching/latched-scroll-remove-iframe.html	2020-10-23 18:35:44 UTC (rev 268932)
+++ trunk/LayoutTests/fast/scrolling/latching/latched-scroll-remove-iframe.html	2020-10-23 18:49:32 UTC (rev 268933)
@@ -13,12 +13,14 @@
         jsTestIsAsync = true;
         
         let iframe = undefined;
-        function iframeScrolled(offset)
+        async function iframeScrolled(offset)
         {
-            if (offset >= 200)
-                iframe.remove();
-            
-            setTimeout(finishJSTest, 16);
+            if (offset < 200)
+                return;
+
+            iframe.remove();
+            await UIHelper.renderingUpdate();
+            finishJSTest();
         }
 
         async function doTest()

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (268932 => 268933)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-10-23 18:35:44 UTC (rev 268932)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-10-23 18:49:32 UTC (rev 268933)
@@ -1285,8 +1285,6 @@
 
 webkit.org/b/215875 [ Debug ] fast/layoutformattingcontext/line-heigt-when-text-is-inside-inline-container.html [ Skip ]
 
-webkit.org/b/216059 fast/scrolling/latching/latched-scroll-remove-iframe.html [ Pass Failure ]
-
 webkit.org/b/216159 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html [ Pass Failure ]
 
 webkit.org/b/216164 [ Catalina Debug ] html5lib/generated/run-template-data.html [ Pass Crash ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to