Title: [269709] trunk
Revision
269709
Author
wenson_hs...@apple.com
Date
2020-11-11 17:16:25 -0800 (Wed, 11 Nov 2020)

Log Message

Add system trace points for the GPU process display list processing loop
https://bugs.webkit.org/show_bug.cgi?id=218824

Reviewed by Simon Fraser.

Source/WebKit:

Capture the time spent applying display list items in the GPU process with a pair of new trace points, to aid
performance debugging and analysis.

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):

Source/WTF:

* wtf/SystemTracing.h:

Tools:

* Tracing/SystemTracePoints.plist:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (269708 => 269709)


--- trunk/Source/WTF/ChangeLog	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Source/WTF/ChangeLog	2020-11-12 01:16:25 UTC (rev 269709)
@@ -1,3 +1,12 @@
+2020-11-11  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Add system trace points for the GPU process display list processing loop
+        https://bugs.webkit.org/show_bug.cgi?id=218824
+
+        Reviewed by Simon Fraser.
+
+        * wtf/SystemTracing.h:
+
 2020-11-11  Alex Christensen  <achristen...@webkit.org>
 
         Define USE(LEGACY_CFNETWORK_DOWNLOADS)

Modified: trunk/Source/WTF/wtf/SystemTracing.h (269708 => 269709)


--- trunk/Source/WTF/wtf/SystemTracing.h	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Source/WTF/wtf/SystemTracing.h	2020-11-12 01:16:25 UTC (rev 269709)
@@ -124,6 +124,10 @@
     ProcessLaunchEnd,
     InitializeSandboxStart,
     InitializeSandboxEnd,
+
+    GPUProcessRange = 16000,
+    WakeUpAndApplyDisplayListStart,
+    WakeUpAndApplyDisplayListEnd,
 };
 
 #ifdef __cplusplus

Modified: trunk/Source/WebKit/ChangeLog (269708 => 269709)


--- trunk/Source/WebKit/ChangeLog	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Source/WebKit/ChangeLog	2020-11-12 01:16:25 UTC (rev 269709)
@@ -1,3 +1,16 @@
+2020-11-11  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Add system trace points for the GPU process display list processing loop
+        https://bugs.webkit.org/show_bug.cgi?id=218824
+
+        Reviewed by Simon Fraser.
+
+        Capture the time spent applying display list items in the GPU process with a pair of new trace points, to aid
+        performance debugging and analysis.
+
+        * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+        (WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):
+
 2020-11-11  Said Abou-Hallawa  <s...@apple.com>
 
         [GPU Process] Cache the NativeImage in GPU Process and allow referencing it with its RemoteResourceIdentifier

Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (269708 => 269709)


--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp	2020-11-12 01:16:25 UTC (rev 269709)
@@ -34,6 +34,7 @@
 #include "RemoteRenderingBackendMessages.h"
 #include "RemoteRenderingBackendProxyMessages.h"
 #include <wtf/CheckedArithmetic.h>
+#include <wtf/SystemTracing.h>
 
 namespace WebKit {
 using namespace WebCore;
@@ -169,6 +170,7 @@
 
 void RemoteRenderingBackend::wakeUpAndApplyDisplayList(DisplayList::ItemBufferIdentifier initialIdentifier, uint64_t initialOffset, RenderingResourceIdentifier destinationBufferIdentifier)
 {
+    TraceScope tracingScope(WakeUpAndApplyDisplayListStart, WakeUpAndApplyDisplayListEnd);
     auto imageBuffer = m_remoteResourceCache.cachedImageBuffer(destinationBufferIdentifier);
     if (UNLIKELY(!imageBuffer)) {
         // FIXME: Add a message check to terminate the web process.

Modified: trunk/Tools/ChangeLog (269708 => 269709)


--- trunk/Tools/ChangeLog	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Tools/ChangeLog	2020-11-12 01:16:25 UTC (rev 269709)
@@ -1,3 +1,12 @@
+2020-11-11  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Add system trace points for the GPU process display list processing loop
+        https://bugs.webkit.org/show_bug.cgi?id=218824
+
+        Reviewed by Simon Fraser.
+
+        * Tracing/SystemTracePoints.plist:
+
 2020-11-11  Ryan Haddad  <ryanhad...@apple.com>
 
         [webkitpy] Bump CURRENT_VERSION to 11.0 for Mac port

Modified: trunk/Tools/Tracing/SystemTracePoints.plist (269708 => 269709)


--- trunk/Tools/Tracing/SystemTracePoints.plist	2020-11-12 00:59:50 UTC (rev 269708)
+++ trunk/Tools/Tracing/SystemTracePoints.plist	2020-11-12 01:16:25 UTC (rev 269709)
@@ -505,6 +505,18 @@
                  <key>CodeEnd</key>
                  <string>14006</string>
              </dict>
+             <dict>
+                 <key>Name</key>
+                 <string>Wake up and apply display list</string>
+                 <key>Type</key>
+                 <string>Interval</string>
+                 <key>Component</key>
+                 <string>47</string>
+                 <key>CodeBegin</key>
+                 <string>16001</string>
+                 <key>CodeEnd</key>
+                 <string>16002</string>
+             </dict>
          </array>
      </dict>
  </array>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to