Title: [270026] trunk/Source/WebCore
- Revision
- 270026
- Author
- za...@apple.com
- Date
- 2020-11-19 06:18:29 -0800 (Thu, 19 Nov 2020)
Log Message
[LFC][Integration] Allow subpixel difference in the computed containing block height when switching between line layout systems
https://bugs.webkit.org/show_bug.cgi?id=219143
Reviewed by Antti Koivisto.
With all the seemingly random flooring, ceiling and rounding in the legacy line layout codebase,
it's really difficult to subpixel match the end result in a sane way in IFC as we start supporting more complex content.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::ensureLineBoxes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (270025 => 270026)
--- trunk/Source/WebCore/ChangeLog 2020-11-19 14:17:12 UTC (rev 270025)
+++ trunk/Source/WebCore/ChangeLog 2020-11-19 14:18:29 UTC (rev 270026)
@@ -1,3 +1,16 @@
+2020-11-19 Zalan Bujtas <za...@apple.com>
+
+ [LFC][Integration] Allow subpixel difference in the computed containing block height when switching between line layout systems
+ https://bugs.webkit.org/show_bug.cgi?id=219143
+
+ Reviewed by Antti Koivisto.
+
+ With all the seemingly random flooring, ceiling and rounding in the legacy line layout codebase,
+ it's really difficult to subpixel match the end result in a sane way in IFC as we start supporting more complex content.
+
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::ensureLineBoxes):
+
2020-11-19 Antti Koivisto <an...@apple.com>
[LFC][Integration] nextLinePosition should use iterator
Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (270025 => 270026)
--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-11-19 14:17:12 UTC (rev 270025)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-11-19 14:18:29 UTC (rev 270026)
@@ -3687,7 +3687,7 @@
complexLineLayout.layoutLineBoxes(relayoutChildren, repaintLogicalTop, repaintLogicalBottom);
updateLogicalHeight();
- ASSERT(didNeedLayout || logicalHeight() == oldHeight);
+ ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight));
if (!didNeedLayout)
clearNeedsLayout();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
