Title: [270138] trunk/Websites/perf.webkit.org
- Revision
- 270138
- Author
- dewei_...@apple.com
- Date
- 2020-11-20 16:51:51 -0800 (Fri, 20 Nov 2020)
Log Message
Fix a bug that platform groups cannot be updated on 'admin/platform'.
https://bugs.webkit.org/show_bug.cgi?id=219118
Reviewed by Ryosuke Niwa.
Admins should be able to update platform group on 'admin/platform'.
Update the assertion on BuildbotTriggerable._pullBuildbotOnAllSyncers so that when there is no
corresponding entry in buildRequestByGroup, the test group for the request should be finished.
* public/admin/platforms.php:
* tools/js/buildbot-triggerable.js: Updated the assert statement.
(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers):
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (270137 => 270138)
--- trunk/Websites/perf.webkit.org/ChangeLog 2020-11-21 00:51:21 UTC (rev 270137)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2020-11-21 00:51:51 UTC (rev 270138)
@@ -1,3 +1,18 @@
+2020-11-18 Dewei Zhu <dewei_...@apple.com>
+
+ Fix a bug that platform groups cannot be updated on 'admin/platform'.
+ https://bugs.webkit.org/show_bug.cgi?id=219118
+
+ Reviewed by Ryosuke Niwa.
+
+ Admins should be able to update platform group on 'admin/platform'.
+ Update the assertion on BuildbotTriggerable._pullBuildbotOnAllSyncers so that when there is no
+ corresponding entry in buildRequestByGroup, the test group for the request should be finished.
+
+ * public/admin/platforms.php:
+ * tools/js/buildbot-triggerable.js: Updated the assert statement.
+ (BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers):
+
2020-11-16 Dewei Zhu <dewei_...@apple.com>
BuildbotTriggerable should not process a completed build request from a completed test group.
Modified: trunk/Websites/perf.webkit.org/public/admin/platforms.php (270137 => 270138)
--- trunk/Websites/perf.webkit.org/public/admin/platforms.php 2020-11-21 00:51:21 UTC (rev 270137)
+++ trunk/Websites/perf.webkit.org/public/admin/platforms.php 2020-11-21 00:51:51 UTC (rev 270138)
@@ -59,9 +59,8 @@
if ($db) {
if ($action == 'update') {
if (update_field('platforms', 'platform', 'name')
- || update_boolean_field('platforms', 'platform', 'hidden')
- || update_field('platforms', 'platform', 'hidden')
- || update_field('platforms', 'platform', 'group'))
+ || update_field('platforms', 'platform', 'group')
+ || update_boolean_field('platforms', 'platform', 'hidden'))
regenerate_manifest();
else
notice('Invalid parameters.');
Modified: trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js (270137 => 270138)
--- trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js 2020-11-21 00:51:21 UTC (rev 270137)
+++ trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js 2020-11-21 00:51:51 UTC (rev 270138)
@@ -179,7 +179,7 @@
const info = buildReqeustsByGroup.get(request.testGroupId());
if (!info) {
- assert(request.hasFinished());
+ assert(request.testGroup().hasFinished());
continue;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
