Title: [270877] trunk/Source/_javascript_Core
- Revision
- 270877
- Author
- sbar...@apple.com
- Date
- 2020-12-15 18:32:22 -0800 (Tue, 15 Dec 2020)
Log Message
destinationFor should check for FTLJIT, not DFGJIT twice
https://bugs.webkit.org/show_bug.cgi?id=219929
Reviewed by Mark Lam.
The code was checking for DFGJIT twice instead of checking for FTLJIT.
This doesn't fix any actual bugs, since nobody passes in FTLJIT to this
function. But if we ever do in the future, it would have revealed this bug.
* bytecode/BytecodeOperandsForCheckpoint.h:
(JSC::destinationFor):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (270876 => 270877)
--- trunk/Source/_javascript_Core/ChangeLog 2020-12-16 02:02:02 UTC (rev 270876)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-12-16 02:32:22 UTC (rev 270877)
@@ -1,3 +1,17 @@
+2020-12-15 Saam Barati <sbar...@apple.com>
+
+ destinationFor should check for FTLJIT, not DFGJIT twice
+ https://bugs.webkit.org/show_bug.cgi?id=219929
+
+ Reviewed by Mark Lam.
+
+ The code was checking for DFGJIT twice instead of checking for FTLJIT.
+ This doesn't fix any actual bugs, since nobody passes in FTLJIT to this
+ function. But if we ever do in the future, it would have revealed this bug.
+
+ * bytecode/BytecodeOperandsForCheckpoint.h:
+ (JSC::destinationFor):
+
2020-12-15 Alexey Shvayka <shvaikal...@gmail.com>
Non-enumerable property fails to shadow inherited enumerable property from for-in
Modified: trunk/Source/_javascript_Core/bytecode/BytecodeOperandsForCheckpoint.h (270876 => 270877)
--- trunk/Source/_javascript_Core/bytecode/BytecodeOperandsForCheckpoint.h 2020-12-16 02:02:02 UTC (rev 270876)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeOperandsForCheckpoint.h 2020-12-16 02:32:22 UTC (rev 270877)
@@ -100,7 +100,7 @@
} else if constexpr (Bytecode::opcodeID == op_iterator_next) {
switch (checkpointIndex) {
case OpIteratorNext::computeNext: {
- if (type == JITType::DFGJIT || type == JITType::DFGJIT)
+ if (type == JITType::DFGJIT || type == JITType::FTLJIT)
return Operand::tmp(OpIteratorNext::nextResult);
return bytecode.m_value; // We reuse value as a temp because its either not used in subsequent bytecodes or written as the temp object .
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
