Title: [271810] trunk/LayoutTests
- Revision
- 271810
- Author
- commit-qu...@webkit.org
- Date
- 2021-01-25 13:25:12 -0800 (Mon, 25 Jan 2021)
Log Message
REGRESSION (Big Sur): Some tests in http/tests/security/http-0.9 flakily fail
https://bugs.webkit.org/show_bug.cgi?id=220188
<rdar://problem/72709565>
Patch by Alex Christensen <achristen...@webkit.org> on 2021-01-25
Reviewed by Alexey Proskuryakov.
rdar://69534004 caused two tests to become flaky on Big Sur.
That change was correct, but caused issues with our test infrastructure.
r271652 successfully made default-port-script-blocked.html no longer flaky, but made default-port-plugin-blocked.html a flaky timeout.
Now that all plugins are blocked, let's just remove this test, which is no longer needed.
* http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt: Removed.
* http/tests/security/http-0.9/default-port-plugin-blocked.html: Removed.
* http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl: Removed.
* platform/mac-wk1/TestExpectations:
* platform/wk2/TestExpectations:
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (271809 => 271810)
--- trunk/LayoutTests/ChangeLog 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/ChangeLog 2021-01-25 21:25:12 UTC (rev 271810)
@@ -1,3 +1,22 @@
+2021-01-25 Alex Christensen <achristen...@webkit.org>
+
+ REGRESSION (Big Sur): Some tests in http/tests/security/http-0.9 flakily fail
+ https://bugs.webkit.org/show_bug.cgi?id=220188
+ <rdar://problem/72709565>
+
+ Reviewed by Alexey Proskuryakov.
+
+ rdar://69534004 caused two tests to become flaky on Big Sur.
+ That change was correct, but caused issues with our test infrastructure.
+ r271652 successfully made default-port-script-blocked.html no longer flaky, but made default-port-plugin-blocked.html a flaky timeout.
+ Now that all plugins are blocked, let's just remove this test, which is no longer needed.
+
+ * http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt: Removed.
+ * http/tests/security/http-0.9/default-port-plugin-blocked.html: Removed.
+ * http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl: Removed.
+ * platform/mac-wk1/TestExpectations:
+ * platform/wk2/TestExpectations:
+
2021-01-25 Ryan Haddad <ryanhad...@apple.com>
Many WPT tests in css/css-color/predefined-*.html failing
Deleted: trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt (271809 => 271810)
--- trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt 2021-01-25 21:25:12 UTC (rev 271810)
@@ -1,16 +0,0 @@
-ALERT: successfully closed one connection
-ALERT: successfully closed one connection
-ALERT: successfully closed one connection
-ALERT: successfully closed one connection
-ALERT: successfully closed one connection
-ALERT: successfully closed one connection
-CONSOLE MESSAGE: Sandboxing 'http://127.0.0.1:8000/security/http-0.9/resources/nph-load-plugin-fail.pl' because it is using HTTP/0.9.
-ALERT: iframe loaded successfully
-This tests that loading of a plugin is blocked in a HTTP 0.9 response served over port 80. This test PASSED if you see content in the iframe below. Otherwise, it FAILED.
-
-
-
---------
-Frame: '<!--frame1-->'
---------
-Plugin did not load.
Deleted: trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked.html (271809 => 271810)
--- trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked.html 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked.html 2021-01-25 21:25:12 UTC (rev 271810)
@@ -1,34 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script>
-if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.dumpChildFramesAsText();
- testRunner.waitUntilDone();
- if (window.internals)
- internals.registerDefaultPortForProtocol(8000, "http");
-}
-
-async function closeConnectionsThenAddFrame() {
- for (var i = 0; i < 6; i = i + 1) {
- try {
- await fetch('resources/close-connection.php', {mode: 'no-cors'});
- alert("successfully closed one connection");
- } catch (e) {
- alert("exception while closing connection " + e);
- }
- }
- var iframe = document.createElement('iframe');
- iframe.src = ""
- iframe._onload_ = function() { alert("iframe loaded successfully"); if (window.testRunner) { testRunner.notifyDone() } }
- iframe._onerror_ = function() { alert("iframe load failed"); if (window.testRunner) { testRunner.notifyDone() } }
- document.body.appendChild(iframe);
-}
-
-</script>
-</head>
-<body _onload_="closeConnectionsThenAddFrame()">
-<p id="description">This tests that loading of a plugin is blocked in a HTTP 0.9 response served over port 80. This test PASSED if you see content in the iframe below. Otherwise, it FAILED.</p>
-</body>
-</html>
Deleted: trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl (271809 => 271810)
--- trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/http/tests/security/http-0.9/resources/nph-load-plugin-fail.pl 2021-01-25 21:25:12 UTC (rev 271810)
@@ -1,11 +0,0 @@
-#!/usr/bin/perl
-# This script relies on its nph- filename to invoke the CGI non-parsed-header facility.
-
-print <<'EOF';
-<!DOCTYPE html>
-<html>
-<body>
-<embed type="application/x-webkit-test-netscape">Plugin did not load.</embed>
-</body>
-</html>
-EOF
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (271809 => 271810)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-01-25 21:25:12 UTC (rev 271810)
@@ -1214,8 +1214,5 @@
webkit.org/b/219498 imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-padding-003.html [ Pass ImageOnlyFailure ]
-webkit.org/b/220188 [ BigSur+ ] http/tests/security/http-0.9/default-port-script-blocked.html [ Pass Failure ]
-webkit.org/b/220188 [ BigSur+ ] http/tests/security/http-0.9/default-port-plugin-blocked.html [ Pass Failure ]
-
webkit.org/b/217761 [ Debug ] webgl/conformance/extensions/s3tc-and-rgtc.html [ Skip ]
webkit.org/b/217761 [ Debug ] webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html [ Skip ]
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (271809 => 271810)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2021-01-25 21:24:23 UTC (rev 271809)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2021-01-25 21:25:12 UTC (rev 271810)
@@ -495,7 +495,6 @@
# Internals.registerDefaultPortForProtocol() does not affect NetworkProcess. We should
# look to remove it and write these test to make use of an HTTP server running on port 80.
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
-http/tests/security/http-0.9/default-port-plugin-blocked.html
http/tests/security/http-0.9/default-port-script-blocked.html
http/tests/security/http-0.9/image-default-port-allowed.html
http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-ref-test.html
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
