Title: [271831] branches/safari-611-branch/Tools
Revision
271831
Author
alanc...@apple.com
Date
2021-01-25 14:11:44 -0800 (Mon, 25 Jan 2021)

Log Message

Cherry-pick r271380. rdar://problem/73477386

    ASSERTION FAILED: !event || event.type == NSEventTypeLeftMouseDown || event.type == NSEventTypeRightMouseDown || event.type == NSEventTypeOtherMouseDown
    https://bugs.webkit.org/show_bug.cgi?id=220520
    <rdar://problem/73007898>

    Reviewed by Tim Horton.

    Fix the assertion by synthesizing a "mouse down" event instead of "mouse entered".

    * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
    (TestWebKitAPI::TEST):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/Tools/ChangeLog (271830 => 271831)


--- branches/safari-611-branch/Tools/ChangeLog	2021-01-25 22:11:41 UTC (rev 271830)
+++ branches/safari-611-branch/Tools/ChangeLog	2021-01-25 22:11:44 UTC (rev 271831)
@@ -1,5 +1,36 @@
 2021-01-25  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r271380. rdar://problem/73477386
+
+    ASSERTION FAILED: !event || event.type == NSEventTypeLeftMouseDown || event.type == NSEventTypeRightMouseDown || event.type == NSEventTypeOtherMouseDown
+    https://bugs.webkit.org/show_bug.cgi?id=220520
+    <rdar://problem/73007898>
+    
+    Reviewed by Tim Horton.
+    
+    Fix the assertion by synthesizing a "mouse down" event instead of "mouse entered".
+    
+    * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
+    (TestWebKitAPI::TEST):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-11  Wenson Hsieh  <wenson_hs...@apple.com>
+
+            ASSERTION FAILED: !event || event.type == NSEventTypeLeftMouseDown || event.type == NSEventTypeRightMouseDown || event.type == NSEventTypeOtherMouseDown
+            https://bugs.webkit.org/show_bug.cgi?id=220520
+            <rdar://problem/73007898>
+
+            Reviewed by Tim Horton.
+
+            Fix the assertion by synthesizing a "mouse down" event instead of "mouse entered".
+
+            * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
+            (TestWebKitAPI::TEST):
+
+2021-01-25  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r271479. rdar://problem/73469631
 
     REGRESSION (r266634): Messages crashes sometimes while scrolling around and playing YouTube videos

Modified: branches/safari-611-branch/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm (271830 => 271831)


--- branches/safari-611-branch/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm	2021-01-25 22:11:41 UTC (rev 271830)
+++ branches/safari-611-branch/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm	2021-01-25 22:11:44 UTC (rev 271831)
@@ -82,7 +82,7 @@
     auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400)]);
     [webView loadHTMLString:@"<body>" baseURL:nil];
 
-    auto mouseEvent = [NSEvent enterExitEventWithType:NSEventTypeMouseEntered location:NSMakePoint(1, 1) modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[webView window].windowNumber context:NSGraphicsContext.currentContext eventNumber:1 trackingNumber:1 userData:nil];
+    auto mouseEvent = [NSEvent mouseEventWithType:NSEventTypeLeftMouseDown location:NSMakePoint(1, 1) modifierFlags:0 timestamp:GetCurrentEventTime() windowNumber:[webView window].windowNumber context:NSGraphicsContext.currentContext eventNumber:1 clickCount:1 pressure:0];
     [webView acceptsFirstMouse:mouseEvent];
 
     [webView _test_waitForDidFinishNavigation];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to