Title: [271857] branches/safari-611-branch
- Revision
- 271857
- Author
- alanc...@apple.com
- Date
- 2021-01-25 14:13:44 -0800 (Mon, 25 Jan 2021)
Log Message
Cherry-pick r271618. rdar://problem/73477509
REGRESSION(r266695) Range control with custom track width sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=220608
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: fast/forms/range/input-range-sizing-fixed-size.html
In r266695 we modified the way min-{width|height}: auto was computed for flexbox elements. That broke the sizing
of input range controls that were working under the assumption that min-{width|height} was 0. We have to force it
in the UA CSS in order to keep the same behaviour.
* css/html.css:
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): force
min-width: 0.
LayoutTests:
New test case to verify that input range controls are sized correctly with specified widths.
* fast/forms/range/input-range-sizing-fixed-size-expected.html: Added.
* fast/forms/range/input-range-sizing-fixed-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Added Paths
Diff
Modified: branches/safari-611-branch/LayoutTests/ChangeLog (271856 => 271857)
--- branches/safari-611-branch/LayoutTests/ChangeLog 2021-01-25 22:13:38 UTC (rev 271856)
+++ branches/safari-611-branch/LayoutTests/ChangeLog 2021-01-25 22:13:44 UTC (rev 271857)
@@ -1,5 +1,48 @@
2021-01-25 Alan Coon <alanc...@apple.com>
+ Cherry-pick r271618. rdar://problem/73477509
+
+ REGRESSION(r266695) Range control with custom track width sized incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=220608
+
+ Reviewed by Zalan Bujtas.
+
+ Source/WebCore:
+
+ Test: fast/forms/range/input-range-sizing-fixed-size.html
+
+ In r266695 we modified the way min-{width|height}: auto was computed for flexbox elements. That broke the sizing
+ of input range controls that were working under the assumption that min-{width|height} was 0. We have to force it
+ in the UA CSS in order to keep the same behaviour.
+
+ * css/html.css:
+ (input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): force
+ min-width: 0.
+
+ LayoutTests:
+
+ New test case to verify that input range controls are sized correctly with specified widths.
+
+ * fast/forms/range/input-range-sizing-fixed-size-expected.html: Added.
+ * fast/forms/range/input-range-sizing-fixed-size.html: Added.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-19 Sergio Villar Senin <svil...@igalia.com>
+
+ REGRESSION(r266695) Range control with custom track width sized incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=220608
+
+ Reviewed by Zalan Bujtas.
+
+ New test case to verify that input range controls are sized correctly with specified widths.
+
+ * fast/forms/range/input-range-sizing-fixed-size-expected.html: Added.
+ * fast/forms/range/input-range-sizing-fixed-size.html: Added.
+
+2021-01-25 Alan Coon <alanc...@apple.com>
+
Cherry-pick r271587. rdar://problem/73477379
Fix for LayoutTests/accessibility/canvas-fallback-content.html in isolated tree mode.
Added: branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size-expected.html (0 => 271857)
--- branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size-expected.html (rev 0)
+++ branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size-expected.html 2021-01-25 22:13:44 UTC (rev 271857)
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<input type="range">
Added: branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size.html (0 => 271857)
--- branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size.html (rev 0)
+++ branches/safari-611-branch/LayoutTests/fast/forms/range/input-range-sizing-fixed-size.html 2021-01-25 22:13:44 UTC (rev 271857)
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<style>
+input[type=range]::-webkit-slider-runnable-track {
+ width: 800px;
+}
+</style>
+<input type="range">
Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (271856 => 271857)
--- branches/safari-611-branch/Source/WebCore/ChangeLog 2021-01-25 22:13:38 UTC (rev 271856)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog 2021-01-25 22:13:44 UTC (rev 271857)
@@ -1,5 +1,53 @@
2021-01-25 Alan Coon <alanc...@apple.com>
+ Cherry-pick r271618. rdar://problem/73477509
+
+ REGRESSION(r266695) Range control with custom track width sized incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=220608
+
+ Reviewed by Zalan Bujtas.
+
+ Source/WebCore:
+
+ Test: fast/forms/range/input-range-sizing-fixed-size.html
+
+ In r266695 we modified the way min-{width|height}: auto was computed for flexbox elements. That broke the sizing
+ of input range controls that were working under the assumption that min-{width|height} was 0. We have to force it
+ in the UA CSS in order to keep the same behaviour.
+
+ * css/html.css:
+ (input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): force
+ min-width: 0.
+
+ LayoutTests:
+
+ New test case to verify that input range controls are sized correctly with specified widths.
+
+ * fast/forms/range/input-range-sizing-fixed-size-expected.html: Added.
+ * fast/forms/range/input-range-sizing-fixed-size.html: Added.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-19 Sergio Villar Senin <svil...@igalia.com>
+
+ REGRESSION(r266695) Range control with custom track width sized incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=220608
+
+ Reviewed by Zalan Bujtas.
+
+ Test: fast/forms/range/input-range-sizing-fixed-size.html
+
+ In r266695 we modified the way min-{width|height}: auto was computed for flexbox elements. That broke the sizing
+ of input range controls that were working under the assumption that min-{width|height} was 0. We have to force it
+ in the UA CSS in order to keep the same behaviour.
+
+ * css/html.css:
+ (input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container): force
+ min-width: 0.
+
+2021-01-25 Alan Coon <alanc...@apple.com>
+
Cherry-pick r271589. rdar://problem/73477370
Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
Modified: branches/safari-611-branch/Source/WebCore/css/html.css (271856 => 271857)
--- branches/safari-611-branch/Source/WebCore/css/html.css 2021-01-25 22:13:38 UTC (rev 271856)
+++ branches/safari-611-branch/Source/WebCore/css/html.css 2021-01-25 22:13:44 UTC (rev 271857)
@@ -834,6 +834,7 @@
box-sizing: border-box;
display: flex;
align-contents: center;
+ min-width: 0;
}
input[type="range"]::-webkit-slider-runnable-track {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
