Title: [271869] trunk/Tools
- Revision
- 271869
- Author
- aakash_j...@apple.com
- Date
- 2021-01-25 16:50:53 -0800 (Mon, 25 Jan 2021)
Log Message
Changes to commit-log-editor should trigger webkitpy EWS tests
https://bugs.webkit.org/show_bug.cgi?id=220953
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps.py:
(CheckPatchRelevance): Added commit-log-editor to list of relevant files for webkitpy ews.
* CISupport/ews-build/steps_unittest.py: Improved unit-test to check for various file-names.
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (271868 => 271869)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-01-26 00:36:31 UTC (rev 271868)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-01-26 00:50:53 UTC (rev 271869)
@@ -374,6 +374,7 @@
webkitpy_paths = [
'Tools/Scripts/webkitpy',
'Tools/Scripts/libraries',
+ 'Tools/Scripts/commit-log-editor',
]
group_to_paths_mapping = {
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (271868 => 271869)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-01-26 00:36:31 UTC (rev 271868)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-01-26 00:50:53 UTC (rev 271869)
@@ -2420,19 +2420,15 @@
return self.runStep()
def test_relevant_webkitpy_patch(self):
- CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/webkitpy'
- self.setupStep(CheckPatchRelevance())
- self.setProperty('buildername', 'WebKitPy-Tests-EWS')
- self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
- return self.runStep()
+ file_names = ['Tools/Scripts/webkitpy', 'Tools/Scripts/libraries', 'Tools/Scripts/commit-log-editor']
+ for file_name in file_names:
+ CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: {}'.format(file_name)
+ self.setupStep(CheckPatchRelevance())
+ self.setProperty('buildername', 'WebKitPy-Tests-EWS')
+ self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
+ rc = self.runStep()
+ return rc
- def test_relevant_libraries_patch(self):
- CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/libraries'
- self.setupStep(CheckPatchRelevance())
- self.setProperty('buildername', 'WebKitPy-Tests-EWS')
- self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
- return self.runStep()
-
def test_queues_without_relevance_info(self):
CheckPatchRelevance._get_patch = lambda x: 'Sample patch'
queues = ['Commit-Queue', 'Style-EWS', 'Apply-WatchList-EWS', 'GTK-Build-EWS', 'GTK-WK2-Tests-EWS',
Modified: trunk/Tools/ChangeLog (271868 => 271869)
--- trunk/Tools/ChangeLog 2021-01-26 00:36:31 UTC (rev 271868)
+++ trunk/Tools/ChangeLog 2021-01-26 00:50:53 UTC (rev 271869)
@@ -1,3 +1,14 @@
+2021-01-25 Aakash Jain <aakash_j...@apple.com>
+
+ Changes to commit-log-editor should trigger webkitpy EWS tests
+ https://bugs.webkit.org/show_bug.cgi?id=220953
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/steps.py:
+ (CheckPatchRelevance): Added commit-log-editor to list of relevant files for webkitpy ews.
+ * CISupport/ews-build/steps_unittest.py: Improved unit-test to check for various file-names.
+
2021-01-25 Jonathan Bedard <jbed...@apple.com>
[run-webkit-tests] Support python layout tests
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
