Title: [272399] trunk/Tools
Revision
272399
Author
aakash_j...@apple.com
Date
2021-02-04 16:55:08 -0800 (Thu, 04 Feb 2021)

Log Message

[build.webkit.org] Update dashboard links for layout test results
https://bugs.webkit.org/show_bug.cgi?id=221280

Reviewed by Jonathan Bedard.

* CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot): Set baseURLForResults.
(Buildbot.prototype.layoutTestResultsDirectoryURLForIteration): Use baseURLForResults if available.
* CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Pass baseURLForResults appropriately.

Modified Paths

Diff

Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js (272398 => 272399)


--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js	2021-02-05 00:54:33 UTC (rev 272398)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js	2021-02-05 00:55:08 UTC (rev 272399)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013-2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -42,6 +42,7 @@
     this._needsAuthentication = typeof options === "object" && options.needsAuthentication === true;
     this._authenticationStatus = Buildbot.AuthenticationStatus.Unauthenticated;
 
+    this.baseURLForResults = options ? options.baseURLForResults : null;
     this.VERSION_LESS_THAN_09 = options && options.USE_BUILDBOT_VERSION_LESS_THAN_09;
 
     if (!this.VERSION_LESS_THAN_09) {
@@ -194,7 +195,11 @@
                 underscoreSeparatedRevisions += iteration.revision[repository.name];
             }
         });
-        return this.baseURL + "results/" + encodeURIComponent(iteration.queue.id) + "/" + encodeURIComponent(underscoreSeparatedRevisions + " (" + iteration.id + ")");
+        var url = "" + "results/";
+        if (this.baseURLForResults) {
+            url = ""
+        }
+        return url + encodeURIComponent(iteration.queue.id) + "/" + encodeURIComponent(underscoreSeparatedRevisions + " (" + iteration.id + ")");
     },
 
     layoutTestResultsURLForIteration: function(iteration)

Modified: trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js (272398 => 272399)


--- trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js	2021-02-05 00:54:33 UTC (rev 272398)
+++ trunk/Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js	2021-02-05 00:55:08 UTC (rev 272399)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2011, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2011-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -95,7 +95,7 @@
         }},
     };
 
-    Buildbot.call(this, "https://build.webkit.org/", queueInfo, {"USE_BUILDBOT_VERSION_LESS_THAN_09" : true});
+    Buildbot.call(this, "https://build.webkit.org/", queueInfo, {"USE_BUILDBOT_VERSION_LESS_THAN_09" : true, "baseURLForResults": "https://s3-us-west-2.amazonaws.com/build.webkit.org-results/"});
 };
 
 BaseObject.addConstructorFunctions(WebKitBuildbot);

Modified: trunk/Tools/ChangeLog (272398 => 272399)


--- trunk/Tools/ChangeLog	2021-02-05 00:54:33 UTC (rev 272398)
+++ trunk/Tools/ChangeLog	2021-02-05 00:55:08 UTC (rev 272399)
@@ -1,3 +1,16 @@
+2021-02-04  Aakash Jain  <aakash_j...@apple.com>
+
+        [build.webkit.org] Update dashboard links for layout test results
+        https://bugs.webkit.org/show_bug.cgi?id=221280
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:
+        (Buildbot): Set baseURLForResults.
+        (Buildbot.prototype.layoutTestResultsDirectoryURLForIteration): Use baseURLForResults if available.
+        * CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
+        (WebKitBuildbot): Pass baseURLForResults appropriately.
+
 2021-02-04  Jonathan Bedard  <jbed...@apple.com>
 
         [Python-3] Change shebang in test-webkitpy (Part-2)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to