Title: [273197] trunk/Source/WebCore
- Revision
- 273197
- Author
- commit-qu...@webkit.org
- Date
- 2021-02-20 02:39:06 -0800 (Sat, 20 Feb 2021)
Log Message
Remove unused isGoogle function
https://bugs.webkit.org/show_bug.cgi?id=222227
Patch by Rob Buis <rb...@igalia.com> on 2021-02-20
Reviewed by Frédéric Wang.
Remove unused (after r273084) isGoogle function.
* platform/UserAgentQuirks.cpp:
(WebCore::isGoogle): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273196 => 273197)
--- trunk/Source/WebCore/ChangeLog 2021-02-20 06:56:06 UTC (rev 273196)
+++ trunk/Source/WebCore/ChangeLog 2021-02-20 10:39:06 UTC (rev 273197)
@@ -1,3 +1,15 @@
+2021-02-20 Rob Buis <rb...@igalia.com>
+
+ Remove unused isGoogle function
+ https://bugs.webkit.org/show_bug.cgi?id=222227
+
+ Reviewed by Frédéric Wang.
+
+ Remove unused (after r273084) isGoogle function.
+
+ * platform/UserAgentQuirks.cpp:
+ (WebCore::isGoogle): Deleted.
+
2021-02-19 Chris Dumez <cdu...@apple.com>
Review remaining usage of autorelease to make sure it is necessary
Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (273196 => 273197)
--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-02-20 06:56:06 UTC (rev 273196)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2021-02-20 10:39:06 UTC (rev 273197)
@@ -35,30 +35,6 @@
// When editing the quirks in this file, be sure to update
// Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp.
-static bool isGoogle(const URL& url)
-{
- String domain = url.host().toString();
- String baseDomain = topPrivatelyControlledDomain(domain);
-
- // Our Google UA is *very* complicated to get right. Read
- // https://webkit.org/b/142074 carefully before changing. Test that 3D
- // view is available in Google Maps. Test Google Calendar. Test logging out
- // and logging in to a Google account. Change platformVersionForUAString()
- // to return "FreeBSD amd64" and test everything again.
- if (baseDomain.startsWith("google."))
- return true;
- if (baseDomain == "gstatic.com")
- return true;
- if (baseDomain == "googleusercontent.com")
- return true;
- // googleapis.com is in the public suffix list, which is confusing. E.g.
- // fonts.googleapis.com is actually a base domain.
- if (domain.endsWith(".googleapis.com"))
- return true;
-
- return false;
-}
-
// Be careful with this quirk: it's an invitation for sites to use _javascript_
// that works in Chrome that WebKit cannot handle. Prefer other quirks instead.
static bool urlRequiresChromeBrowser(const URL& url)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
