Title: [273401] branches/safari-611-branch/Source/WebKit
Revision
273401
Author
repst...@apple.com
Date
2021-02-24 09:10:46 -0800 (Wed, 24 Feb 2021)

Log Message

Cherry-pick r273289. rdar://problem/74623623

    UserMediaPermissionRequestManagerProxy may be released while computing capture device list
    https://bugs.webkit.org/show_bug.cgi?id=222236
    <rdar://74480265>

    Unreviewed, address post-review comment.

    * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
    (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
    captured `this`.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/Source/WebKit/ChangeLog (273400 => 273401)


--- branches/safari-611-branch/Source/WebKit/ChangeLog	2021-02-24 17:10:43 UTC (rev 273400)
+++ branches/safari-611-branch/Source/WebKit/ChangeLog	2021-02-24 17:10:46 UTC (rev 273401)
@@ -1,5 +1,35 @@
 2021-02-23  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r273289. rdar://problem/74623623
+
+    UserMediaPermissionRequestManagerProxy may be released while computing capture device list
+    https://bugs.webkit.org/show_bug.cgi?id=222236
+    <rdar://74480265>
+    
+    Unreviewed, address post-review comment.
+    
+    
+    * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+    (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
+    captured `this`.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-02-22  Eric Carlson  <eric.carl...@apple.com>
+
+            UserMediaPermissionRequestManagerProxy may be released while computing capture device list
+            https://bugs.webkit.org/show_bug.cgi?id=222236
+            <rdar://74480265>
+
+            Unreviewed, address post-review comment.
+
+            * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+            (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
+            captured `this`.
+
+2021-02-23  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r273286. rdar://problem/74622950
 
     [Cocoa] Send sandbox extensions for Network Extension services in load parameters

Modified: branches/safari-611-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (273400 => 273401)


--- branches/safari-611-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2021-02-24 17:10:43 UTC (rev 273400)
+++ branches/safari-611-branch/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2021-02-24 17:10:46 UTC (rev 273401)
@@ -726,7 +726,7 @@
             filteredDevices.append(revealIdsAndLabels ? device : CaptureDevice({ }, device.type(), { }, { }));
         }
 
-        weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels;
+        m_hasFilteredDeviceList = !revealIdsAndLabels;
         ALWAYS_LOG(LOGIDENTIFIER, filteredDevices.size(), " devices revealed");
 
         completion(WTFMove(filteredDevices));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to