Title: [273418] trunk
- Revision
- 273418
- Author
- ryanhad...@apple.com
- Date
- 2021-02-24 12:03:05 -0800 (Wed, 24 Feb 2021)
Log Message
Unreviewed, reverting r273373.
The test added with this change is frequently failing
Reverted changeset:
"Null check ArrayBufferView RefPtr"
https://bugs.webkit.org/show_bug.cgi?id=221569
https://commits.webkit.org/r273373
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273417 => 273418)
--- trunk/LayoutTests/ChangeLog 2021-02-24 19:50:20 UTC (rev 273417)
+++ trunk/LayoutTests/ChangeLog 2021-02-24 20:03:05 UTC (rev 273418)
@@ -1,3 +1,15 @@
+2021-02-24 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r273373.
+
+ The test added with this change is frequently failing
+
+ Reverted changeset:
+
+ "Null check ArrayBufferView RefPtr"
+ https://bugs.webkit.org/show_bug.cgi?id=221569
+ https://commits.webkit.org/r273373
+
2021-02-24 Robert Jenner <jen...@apple.com>
[ macOS Wk2 ] inspector/dom/attributeModified.html is flakey timing out
Deleted: trunk/LayoutTests/crypto/crypto-random-values-oom-expected.txt (273417 => 273418)
--- trunk/LayoutTests/crypto/crypto-random-values-oom-expected.txt 2021-02-24 19:50:20 UTC (rev 273417)
+++ trunk/LayoutTests/crypto/crypto-random-values-oom-expected.txt 2021-02-24 20:03:05 UTC (rev 273418)
@@ -1,11 +0,0 @@
-Test crypto.getRandomValues behavior in oom situation.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS exceptionString == undefined || exceptionString === "TypeError: Argument 1 ('array') to Crypto.getRandomValues must be an instance of ArrayBufferView" is true
-PASS crypto.getRandomValues didn't crash
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/crypto/crypto-random-values-oom.html (273417 => 273418)
--- trunk/LayoutTests/crypto/crypto-random-values-oom.html 2021-02-24 19:50:20 UTC (rev 273417)
+++ trunk/LayoutTests/crypto/crypto-random-values-oom.html 2021-02-24 20:03:05 UTC (rev 273418)
@@ -1,44 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<script src=""
-</head>
-<body>
-<script>
-description("Test crypto.getRandomValues behavior in oom situation.")
-
-let exceptionString = undefined;
-
-function useAllMemory() {
- const a = [0];
- a.__proto__ = {};
- Object.defineProperty(a, 0, {get: foo});
- Object.defineProperty(a, 80000000, {});
-
- function foo() {
- new Uint8Array(a);
- }
-
- new Promise(foo);
- try {
- for (let i = 0; i < 2**32; i++) {
- new ArrayBuffer(1000);
- }
- } catch {
- }
-}
-
-useAllMemory();
-try {
- crypto.getRandomValues(new Uint8Array());
-} catch (e) {
- gc();
- exceptionString = e.toString();
-}
-gc();
-shouldBeTrue("exceptionString == undefined || exceptionString === \"TypeError: Argument 1 ('array') to Crypto.getRandomValues must be an instance of ArrayBufferView\"");
-testPassed("crypto.getRandomValues didn't crash");
-</script>
-</body>
-</html>
Modified: trunk/Source/_javascript_Core/ChangeLog (273417 => 273418)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-24 19:50:20 UTC (rev 273417)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-24 20:03:05 UTC (rev 273418)
@@ -1,3 +1,15 @@
+2021-02-24 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r273373.
+
+ The test added with this change is frequently failing
+
+ Reverted changeset:
+
+ "Null check ArrayBufferView RefPtr"
+ https://bugs.webkit.org/show_bug.cgi?id=221569
+ https://commits.webkit.org/r273373
+
2021-02-24 Rob Buis <rb...@igalia.com>
Null check ArrayBufferView RefPtr
Modified: trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h (273417 => 273418)
--- trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h 2021-02-24 19:50:20 UTC (rev 273417)
+++ trunk/Source/_javascript_Core/runtime/JSArrayBufferViewInlines.h 2021-02-24 20:03:05 UTC (rev 273418)
@@ -76,7 +76,7 @@
inline RefPtr<ArrayBufferView> JSArrayBufferView::unsharedImpl()
{
RefPtr<ArrayBufferView> result = possiblySharedImpl();
- RELEASE_ASSERT(!result || !result->isShared());
+ RELEASE_ASSERT(!result->isShared());
return result;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
