Title: [273467] trunk
- Revision
- 273467
- Author
- commit-qu...@webkit.org
- Date
- 2021-02-24 18:43:19 -0800 (Wed, 24 Feb 2021)
Log Message
Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=222360
Patch by Imanol Fernandez <ifernan...@igalia.com> on 2021-02-24
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Update WebXR xrCompatible attribute test expectations.
* web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added.
Source/WebCore:
Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes()
after WebGLRenderingContextBase::makeXRCompatible call succeeds.
Test: webGLCanvasContext_create_xrcompatible.https.html
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getContextAttributes):
LayoutTests:
Update WebXR xrCompatible attribute test expectations.
* platform/wpe/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273466 => 273467)
--- trunk/LayoutTests/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466)
+++ trunk/LayoutTests/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467)
@@ -1,3 +1,14 @@
+2021-02-24 Imanol Fernandez <ifernan...@igalia.com>
+
+ Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
+ https://bugs.webkit.org/show_bug.cgi?id=222360
+
+ Reviewed by Sam Weinig.
+
+ Update WebXR xrCompatible attribute test expectations.
+
+ * platform/wpe/TestExpectations:
+
2021-02-24 Jean-Yves Avenard <j...@apple.com>
[MSE] Media segment is incorrectly dropped when using negative timestampOffset or when source buffer appendWindow is set.
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (273466 => 273467)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467)
@@ -1,3 +1,14 @@
+2021-02-24 Imanol Fernandez <ifernan...@igalia.com>
+
+ Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
+ https://bugs.webkit.org/show_bug.cgi?id=222360
+
+ Reviewed by Sam Weinig.
+
+ Update WebXR xrCompatible attribute test expectations.
+
+ * web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt: Added.
+
2021-02-24 Ziran Sun <z...@igalia.com>
[css-grid] Fix min/max widths of grid affected by ancestor
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt (0 => 273467)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https-expected.txt 2021-02-25 02:43:19 UTC (rev 273467)
@@ -0,0 +1,4 @@
+
+PASS Verify promise from a non-reentrant to makeXRCompatible() is resolved
+PASS Verify promises from reentrant calls to makeXRCompatible() are resolved
+
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (273466 => 273467)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-25 02:32:04 UTC (rev 273466)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-25 02:43:19 UTC (rev 273467)
@@ -628,7 +628,9 @@
# WebXR
webkit.org/b/212897 imported/w3c/web-platform-tests/webxr/idlharness.https.window.html [ Failure ]
+webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html [ Pass ]
+webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/webGLCanvasContext_makecompatible_reentrant.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html [ Pass ]
webkit.org/b/209859 imported/w3c/web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (273466 => 273467)
--- trunk/Source/WebCore/ChangeLog 2021-02-25 02:32:04 UTC (rev 273466)
+++ trunk/Source/WebCore/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467)
@@ -1,3 +1,18 @@
+2021-02-24 Imanol Fernandez <ifernan...@igalia.com>
+
+ Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
+ https://bugs.webkit.org/show_bug.cgi?id=222360
+
+ Reviewed by Sam Weinig.
+
+ Fixes xrCompatibe false value in WebGLRenderingContextBase::getContextAttributes()
+ after WebGLRenderingContextBase::makeXRCompatible call succeeds.
+
+ Test: webGLCanvasContext_create_xrcompatible.https.html
+
+ * html/canvas/WebGLRenderingContextBase.cpp:
+ (WebCore::WebGLRenderingContextBase::getContextAttributes):
+
2021-02-23 Darin Adler <da...@apple.com>
[iOS] Reduce use of retain/release in WAKWindow and remove unneeded methods from that class
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (273466 => 273467)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2021-02-25 02:32:04 UTC (rev 273466)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2021-02-25 02:43:19 UTC (rev 273467)
@@ -2922,6 +2922,9 @@
attributes.depth = false;
if (!m_attributes.stencil)
attributes.stencil = false;
+#if ENABLE(WEBXR)
+ attributes.xrCompatible = m_isXRCompatible;
+#endif
return attributes;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
