Title: [273468] trunk/Source/WebCore
- Revision
- 273468
- Author
- commit-qu...@webkit.org
- Date
- 2021-02-24 19:34:53 -0800 (Wed, 24 Feb 2021)
Log Message
Crash in CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()
https://bugs.webkit.org/show_bug.cgi?id=222339
Patch by Julian Gonzalez <julian_a_gonza...@apple.com> on 2021-02-24
Reviewed by Ryosuke Niwa.
Make a copy of Ref<HTMLBRElement> when inserting before highest blockquote node.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273467 => 273468)
--- trunk/Source/WebCore/ChangeLog 2021-02-25 02:43:19 UTC (rev 273467)
+++ trunk/Source/WebCore/ChangeLog 2021-02-25 03:34:53 UTC (rev 273468)
@@ -1,3 +1,15 @@
+2021-02-24 Julian Gonzalez <julian_a_gonza...@apple.com>
+
+ Crash in CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph()
+ https://bugs.webkit.org/show_bug.cgi?id=222339
+
+ Reviewed by Ryosuke Niwa.
+
+ Make a copy of Ref<HTMLBRElement> when inserting before highest blockquote node.
+
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
+
2021-02-24 Imanol Fernandez <ifernan...@igalia.com>
Set xrCompatible in WebGLRenderingContextBase::getContextAttributes
Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (273467 => 273468)
--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2021-02-25 02:43:19 UTC (rev 273467)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2021-02-25 03:34:53 UTC (rev 273468)
@@ -1602,7 +1602,7 @@
auto* brPtr = br.ptr();
// We want to replace this quoted paragraph with an unquoted one, so insert a br
// to hold the caret before the highest blockquote.
- insertNodeBefore(WTFMove(br), *highestBlockquote);
+ insertNodeBefore(br.copyRef(), *highestBlockquote);
VisiblePosition atBR(positionBeforeNode(brPtr));
// If the br we inserted collapsed, for example foo<br><blockquote>...</blockquote>, insert
// a second one.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
