Title: [273642] trunk/Source/WebCore
- Revision
- 273642
- Author
- wei...@apple.com
- Date
- 2021-02-28 18:26:00 -0800 (Sun, 28 Feb 2021)
Log Message
Consider removing iOS only CSS property alias -webkit-hyphenate-locale introduced in r80288
https://bugs.webkit.org/show_bug.cgi?id=222507
Reviewed by Anders Carlsson.
It's been about 10 years, let's try removing the iOS only CSS property alias for
-webkit-locale, -webkit-hyphenate-locale, and see what happens.
* css/CSSStyleDeclaration.cpp:
* css/parser/CSSPropertyParser.cpp:
(WebCore::cssPropertyID):
(WebCore::cssPropertyNameIOSAliasing): Deleted.
* css/parser/CSSPropertyParser.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273641 => 273642)
--- trunk/Source/WebCore/ChangeLog 2021-03-01 00:47:26 UTC (rev 273641)
+++ trunk/Source/WebCore/ChangeLog 2021-03-01 02:26:00 UTC (rev 273642)
@@ -1,3 +1,19 @@
+2021-02-28 Sam Weinig <wei...@apple.com>
+
+ Consider removing iOS only CSS property alias -webkit-hyphenate-locale introduced in r80288
+ https://bugs.webkit.org/show_bug.cgi?id=222507
+
+ Reviewed by Anders Carlsson.
+
+ It's been about 10 years, let's try removing the iOS only CSS property alias for
+ -webkit-locale, -webkit-hyphenate-locale, and see what happens.
+
+ * css/CSSStyleDeclaration.cpp:
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::cssPropertyID):
+ (WebCore::cssPropertyNameIOSAliasing): Deleted.
+ * css/parser/CSSPropertyParser.h:
+
2021-02-28 Zalan Bujtas <za...@apple.com>
[LFC][IFC] Content left offset means just content left
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (273641 => 273642)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2021-03-01 00:47:26 UTC (rev 273641)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2021-03-01 02:26:00 UTC (rev 273642)
@@ -184,10 +184,6 @@
*bufferPtr = '\0';
unsigned outputLength = bufferPtr - buffer;
-#if PLATFORM(IOS_FAMILY)
- cssPropertyNameIOSAliasing(buffer, name, outputLength);
-#endif
-
auto hashTableEntry = findProperty(name, outputLength);
if (!hashTableEntry)
return CSSPropertyInvalid;
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (273641 => 273642)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-03-01 00:47:26 UTC (rev 273641)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-03-01 02:26:00 UTC (rev 273642)
@@ -96,18 +96,6 @@
return false;
}
-#if PLATFORM(IOS_FAMILY)
-void cssPropertyNameIOSAliasing(const char* propertyName, const char*& propertyNameAlias, unsigned& newLength)
-{
- if (!strcmp(propertyName, "-webkit-hyphenate-locale")) {
- // Worked in iOS 4.2.
- static const char webkitLocale[] = "-webkit-locale";
- propertyNameAlias = webkitLocale;
- newLength = strlen(webkitLocale);
- }
-}
-#endif
-
template <typename CharacterType>
static CSSPropertyID cssPropertyID(const CharacterType* propertyName, unsigned length)
{
@@ -121,15 +109,7 @@
}
buffer[length] = '\0';
- const char* name = buffer;
- if (buffer[0] == '-') {
-#if PLATFORM(IOS_FAMILY)
- cssPropertyNameIOSAliasing(buffer, name, length);
-#endif
- }
-
- const Property* hashTableEntry = findProperty(name, length);
- if (hashTableEntry) {
+ if (auto hashTableEntry = findProperty(buffer, length)) {
auto propertyID = static_cast<CSSPropertyID>(hashTableEntry->id);
// FIXME: Should take account for flags in settings().
if (isEnabledCSSProperty(propertyID))
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.h (273641 => 273642)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.h 2021-03-01 00:47:26 UTC (rev 273641)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.h 2021-03-01 02:26:00 UTC (rev 273642)
@@ -128,8 +128,4 @@
WEBCORE_EXPORT CSSValueID cssValueKeywordID(StringView);
bool isCustomPropertyName(const String&);
-#if PLATFORM(IOS_FAMILY)
-void cssPropertyNameIOSAliasing(const char* propertyName, const char*& propertyNameAlias, unsigned& newLength);
-#endif
-
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
