Title: [273959] trunk/Source/WebCore
- Revision
- 273959
- Author
- ph...@webkit.org
- Date
- 2021-03-05 03:15:27 -0800 (Fri, 05 Mar 2021)
Log Message
Unreviewed, final (hopefully) WPE/GTK follow-up to r273951
Rubber-stamped by Xabier Rodriguez-Calvar.
* platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::GStreamerSampleFromLibWebRTCVideoFrame): Move WARN_UNUSED_RETURN to header file
and fix pessimizing-move warning.
* platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273958 => 273959)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 10:54:42 UTC (rev 273958)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 11:15:27 UTC (rev 273959)
@@ -1,3 +1,14 @@
+2021-03-05 Philippe Normand <pnorm...@igalia.com>
+
+ Unreviewed, final (hopefully) WPE/GTK follow-up to r273951
+
+ Rubber-stamped by Xabier Rodriguez-Calvar.
+
+ * platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
+ (WebCore::GStreamerSampleFromLibWebRTCVideoFrame): Move WARN_UNUSED_RETURN to header file
+ and fix pessimizing-move warning.
+ * platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
+
2021-03-03 Sergio Villar Senin <svil...@igalia.com>
[css-flexbox] Fix mainAxisLengthIsDefinite for orthogonal items with percentage sizes
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp (273958 => 273959)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp 2021-03-05 10:54:42 UTC (rev 273958)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp 2021-03-05 11:15:27 UTC (rev 273959)
@@ -27,7 +27,7 @@
namespace WebCore {
-WARN_UNUSED_RETURN GRefPtr<GstSample>&& GStreamerSampleFromLibWebRTCVideoFrame(const webrtc::VideoFrame& frame)
+GRefPtr<GstSample> GStreamerSampleFromLibWebRTCVideoFrame(const webrtc::VideoFrame& frame)
{
if (frame.video_frame_buffer()->type() == webrtc::VideoFrameBuffer::Type::kNative) {
auto* framebuffer = static_cast<GStreamerVideoFrameLibWebRTC*>(frame.video_frame_buffer().get());
@@ -57,7 +57,7 @@
auto caps = adoptGRef(gst_video_info_to_caps(&info));
auto sample = adoptGRef(gst_sample_new(buffer.get(), caps.get(), nullptr, nullptr));
- return WTFMove(sample);
+ return sample;
}
rtc::scoped_refptr<webrtc::VideoFrameBuffer> GStreamerVideoFrameLibWebRTC::create(GRefPtr<GstSample>&& sample)
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h (273958 => 273959)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h 2021-03-05 10:54:42 UTC (rev 273958)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h 2021-03-05 11:15:27 UTC (rev 273959)
@@ -31,7 +31,7 @@
namespace WebCore {
-GRefPtr<GstSample>&& GStreamerSampleFromLibWebRTCVideoFrame(const webrtc::VideoFrame&);
+WARN_UNUSED_RETURN GRefPtr<GstSample> GStreamerSampleFromLibWebRTCVideoFrame(const webrtc::VideoFrame&);
std::unique_ptr<webrtc::VideoFrame> LibWebRTCVideoFrameFromGStreamerSample(GRefPtr<GstSample>&&, webrtc::VideoRotation, int64_t timestamp, int64_t renderTimeMs);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
