Title: [274015] trunk/Source/WebCore
- Revision
- 274015
- Author
- drou...@apple.com
- Date
- 2021-03-05 15:49:36 -0800 (Fri, 05 Mar 2021)
Log Message
[Payment Request] expose `dispatchIfShowing` in `MockPaymentCoordinator.cpp` for WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=222833
<rdar://problem/74525927>
Reviewed by Wenson Hsieh.
* testing/MockPaymentCoordinator.h:
* testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::dispatchIfShowing): added.
(WebCore::dispatchIfShowing): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274014 => 274015)
--- trunk/Source/WebCore/ChangeLog 2021-03-05 23:47:15 UTC (rev 274014)
+++ trunk/Source/WebCore/ChangeLog 2021-03-05 23:49:36 UTC (rev 274015)
@@ -1,5 +1,18 @@
2021-03-05 Devin Rousso <drou...@apple.com>
+ [Payment Request] expose `dispatchIfShowing` in `MockPaymentCoordinator.cpp` for WebKitAdditions
+ https://bugs.webkit.org/show_bug.cgi?id=222833
+ <rdar://problem/74525927>
+
+ Reviewed by Wenson Hsieh.
+
+ * testing/MockPaymentCoordinator.h:
+ * testing/MockPaymentCoordinator.cpp:
+ (WebCore::MockPaymentCoordinator::dispatchIfShowing): added.
+ (WebCore::dispatchIfShowing): Deleted.
+
+2021-03-05 Devin Rousso <drou...@apple.com>
+
[Payment Request] if `requestShipping: false` then we should not show any `PaymentShippingOption` in the Apple Pay sheet
https://bugs.webkit.org/show_bug.cgi?id=222810
<rdar://problem/74550889>
Modified: trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp (274014 => 274015)
--- trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp 2021-03-05 23:47:15 UTC (rev 274014)
+++ trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp 2021-03-05 23:49:36 UTC (rev 274015)
@@ -94,7 +94,7 @@
static uint64_t showCount;
static uint64_t hideCount;
-static void dispatchIfShowing(Function<void()>&& function)
+void MockPaymentCoordinator::dispatchIfShowing(Function<void()>&& function)
{
ASSERT(showCount > hideCount);
RunLoop::main().dispatch([currentShowCount = showCount, function = WTFMove(function)]() {
Modified: trunk/Source/WebCore/testing/MockPaymentCoordinator.h (274014 => 274015)
--- trunk/Source/WebCore/testing/MockPaymentCoordinator.h 2021-03-05 23:47:15 UTC (rev 274014)
+++ trunk/Source/WebCore/testing/MockPaymentCoordinator.h 2021-03-05 23:49:36 UTC (rev 274015)
@@ -105,6 +105,8 @@
void getSetupFeatures(const ApplePaySetupConfiguration&, const URL&, CompletionHandler<void(Vector<Ref<ApplePaySetupFeature>>&&)>&&) final;
void beginApplePaySetup(const ApplePaySetupConfiguration&, const URL&, Vector<RefPtr<ApplePaySetupFeature>>&&, CompletionHandler<void(bool)>&&) final;
+ void dispatchIfShowing(Function<void()>&&);
+
Page& m_page;
bool m_canMakePayments { true };
bool m_canMakePaymentsWithActiveCard { true };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
