Title: [274180] trunk/Source/WebCore
Revision
274180
Author
n...@apple.com
Date
2021-03-09 15:22:49 -0800 (Tue, 09 Mar 2021)

Log Message

REGRESSION: [BigSur] ASSERT NOT REACHED in WebCore::ResourceLoadPriority WebCore::toResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=222998

Unreviewed, fix the debug assert caused by r274161.

CFURLRequestGetRequestPriority can return -1 for requests with no priority set (e.g. some
requests from the media stack). We need to handle this case when transforming a
CFURLRequestPriority to a ResourceLoadPriority.

* platform/network/cf/ResourceRequestCFNet.h:
(WebCore::toResourceLoadPriority):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (274179 => 274180)


--- trunk/Source/WebCore/ChangeLog	2021-03-09 23:08:41 UTC (rev 274179)
+++ trunk/Source/WebCore/ChangeLog	2021-03-09 23:22:49 UTC (rev 274180)
@@ -1,3 +1,17 @@
+2021-03-09  Ben Nham  <n...@apple.com>
+
+        REGRESSION: [BigSur] ASSERT NOT REACHED in WebCore::ResourceLoadPriority WebCore::toResourceLoadPriority
+        https://bugs.webkit.org/show_bug.cgi?id=222998
+
+        Unreviewed, fix the debug assert caused by r274161.
+
+        CFURLRequestGetRequestPriority can return -1 for requests with no priority set (e.g. some
+        requests from the media stack). We need to handle this case when transforming a
+        CFURLRequestPriority to a ResourceLoadPriority.
+
+        * platform/network/cf/ResourceRequestCFNet.h:
+        (WebCore::toResourceLoadPriority):
+
 2021-03-09  Eric Carlson  <eric.carl...@apple.com>
 
         [GPU Process] MSE videos are unable to AirPlay

Modified: trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.h (274179 => 274180)


--- trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.h	2021-03-09 23:08:41 UTC (rev 274179)
+++ trunk/Source/WebCore/platform/network/cf/ResourceRequestCFNet.h	2021-03-09 23:22:49 UTC (rev 274180)
@@ -48,6 +48,7 @@
 inline ResourceLoadPriority toResourceLoadPriority(CFURLRequestPriority priority)
 {
     switch (priority) {
+    case -1:
     case 0:
         return ResourceLoadPriority::VeryLow;
     case 1:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to