Title: [274434] trunk/LayoutTests
- Revision
- 274434
- Author
- s...@apple.com
- Date
- 2021-03-15 13:11:48 -0700 (Mon, 15 Mar 2021)
Log Message
Enable the layout test 2d.path.stroke.scale2.html
https://bugs.webkit.org/show_bug.cgi?id=223176
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
* web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt:
LayoutTests:
This layout test is now fixed on macOS and iOS after enabling GPUP for
2D canvas rendering. The reason is CGPathAddRect() has a bug which is
tracked by rdar://75419465. Encoding the CGPath converts the rectangle
command to moveTo and lineTo commands. This is unintentional workaround
for the CGPathAddRect() bug.
* TestExpectations:
* platform/ios-wk1/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (274433 => 274434)
--- trunk/LayoutTests/ChangeLog 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/ChangeLog 2021-03-15 20:11:48 UTC (rev 274434)
@@ -1,3 +1,22 @@
+2021-03-15 Said Abou-Hallawa <s...@apple.com>
+
+ Enable the layout test 2d.path.stroke.scale2.html
+ https://bugs.webkit.org/show_bug.cgi?id=223176
+
+ Reviewed by Tim Horton.
+
+ This layout test is now fixed on macOS and iOS after enabling GPUP for
+ 2D canvas rendering. The reason is CGPathAddRect() has a bug which is
+ tracked by rdar://75419465. Encoding the CGPath converts the rectangle
+ command to moveTo and lineTo commands. This is unintentional workaround
+ for the CGPathAddRect() bug.
+
+ * TestExpectations:
+ * platform/ios-wk1/TestExpectations:
+ * platform/ios/TestExpectations:
+ * platform/mac-wk1/TestExpectations:
+ * platform/mac/TestExpectations:
+
2021-03-15 Robert Jenner <jen...@apple.com>
[ macOS wk2 ARM64 ] http/tests/local/loading-stylesheet-import-remove.html is a flakey image failure
Modified: trunk/LayoutTests/TestExpectations (274433 => 274434)
--- trunk/LayoutTests/TestExpectations 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/TestExpectations 2021-03-15 20:11:48 UTC (rev 274434)
@@ -4077,7 +4077,6 @@
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height-orientation-none.tentative.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height.tentative.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element.tentative.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
# Sometimes prints weird output at the beginning of the tests.
imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas [ Failure Pass ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (274433 => 274434)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-03-15 20:11:48 UTC (rev 274434)
@@ -1,3 +1,12 @@
+2021-03-15 Said Abou-Hallawa <s...@apple.com>
+
+ Enable the layout test 2d.path.stroke.scale2.html
+ https://bugs.webkit.org/show_bug.cgi?id=223176
+
+ Reviewed by Tim Horton.
+
+ * web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt:
+
2021-03-15 Imanol Fernandez <ifernan...@igalia.com>
Split WebXR features into enabledFeatures, supportedFeatures and requestedFeatures
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt (274433 => 274434)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt 2021-03-15 20:11:48 UTC (rev 274434)
@@ -4,5 +4,5 @@
Expected output:
-FAIL Stroke line widths are scaled by the current transformation matrix assert_equals: Red channel of the pixel at (0, 0) expected 0 but got 255
+PASS Stroke line widths are scaled by the current transformation matrix
Modified: trunk/LayoutTests/platform/ios/TestExpectations (274433 => 274434)
--- trunk/LayoutTests/platform/ios/TestExpectations 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2021-03-15 20:11:48 UTC (rev 274434)
@@ -3242,7 +3242,6 @@
fast/scrolling/ios/body-overflow-hidden.html [ Pass ImageOnlyFailure ]
# https://bugs.webkit.org/show_bug.cgi?id=175736
-canvas/philip/tests/2d.path.stroke.scale2.html [ Failure ]
fast/canvas/canvas-currentColor.html [ Failure ]
imported/w3c/canvas/2d.gradient.radial.cone.bottom.html [ Failure ]
imported/w3c/canvas/2d.gradient.radial.cone.cylinder.html [ Failure ]
@@ -3258,7 +3257,6 @@
imported/w3c/canvas/2d.gradient.radial.touch1.html [ Failure ]
imported/w3c/canvas/2d.gradient.radial.touch2.html [ Failure ]
imported/w3c/canvas/2d.gradient.radial.touch3.html [ Failure ]
-imported/w3c/canvas/2d.path.stroke.scale2.html [ Failure ]
# These tests fail with tiny (0.01%) image diffs with accelerated drawing enabled.
accessibility/smart-invert-reference.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (274433 => 274434)
--- trunk/LayoutTests/platform/ios-wk1/TestExpectations 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations 2021-03-15 20:11:48 UTC (rev 274434)
@@ -1954,3 +1954,7 @@
# Stale-while-revalidate is not supported on WK1
imported/w3c/web-platform-tests/fetch/stale-while-revalidate [ Skip ]
+
+webkit.org/b/223193 canvas/philip/tests/2d.path.stroke.scale2.html [ Failure ]
+webkit.org/b/223193 imported/w3c/canvas/2d.path.stroke.scale2.html [ Failure ]
+webkit.org/b/223193 imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (274433 => 274434)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-03-15 20:11:48 UTC (rev 274434)
@@ -1390,10 +1390,6 @@
fast/dom/HTMLMeterElement/meter-appearances-capacity.html [ Failure ]
fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html [ Failure ]
-# <rdar://problem/32620024> REGRESSION: LayoutTests canvas/philip/tests/2d.path.stroke.scale2.html and imported/w3c/canvas/2d.path.stroke.scale2.html are failing
-canvas/philip/tests/2d.path.stroke.scale2.html [ Failure ]
-imported/w3c/canvas/2d.path.stroke.scale2.html [ Failure ]
-
# <rdar://problem/32826391> LayoutTest imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm is failing on High Sierra
imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm [ Failure ]
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (274433 => 274434)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-03-15 20:02:03 UTC (rev 274433)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-03-15 20:11:48 UTC (rev 274434)
@@ -1260,4 +1260,8 @@
webkit.org/b/222693 [ BigSur Release ] media/video-aspect-ratio.html [ Failure Timeout ]
-webkit.org/b/223104 compositing/visibility/iframe-visibility-hidden.html [ Pass ImageOnlyFailure ]
\ No newline at end of file
+webkit.org/b/223104 compositing/visibility/iframe-visibility-hidden.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/223193 canvas/philip/tests/2d.path.stroke.scale2.html [ Failure ]
+webkit.org/b/223193 imported/w3c/canvas/2d.path.stroke.scale2.html [ Failure ]
+webkit.org/b/223193 imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
