Title: [274499] trunk/Source/WebKitLegacy/mac
Revision
274499
Author
an...@apple.com
Date
2021-03-16 11:35:16 -0700 (Tue, 16 Mar 2021)

Log Message

[WebView _touchEventRegions] needs to take the web lock
https://bugs.webkit.org/show_bug.cgi?id=223266

Reviewed by Simon Fraser.

Clicking anything in UIWebView test app in debug build hits thread assert immediately.

* WebView/WebView.mm:
(-[WebView _touchEventRegions]):

Modified Paths

Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (274498 => 274499)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-03-16 18:22:23 UTC (rev 274498)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-03-16 18:35:16 UTC (rev 274499)
@@ -1,3 +1,15 @@
+2021-03-16  Antti Koivisto  <an...@apple.com>
+
+        [WebView _touchEventRegions] needs to take the web lock
+        https://bugs.webkit.org/show_bug.cgi?id=223266
+
+        Reviewed by Simon Fraser.
+
+        Clicking anything in UIWebView test app in debug build hits thread assert immediately.
+
+        * WebView/WebView.mm:
+        (-[WebView _touchEventRegions]):
+
 2021-03-11  Chris Dumez  <cdu...@apple.com>
 
         Introduce WorkQueue::main() to get the main thread's work queue

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (274498 => 274499)


--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2021-03-16 18:22:23 UTC (rev 274498)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2021-03-16 18:35:16 UTC (rev 274499)
@@ -4022,6 +4022,10 @@
 
 - (NSArray *)_touchEventRegions
 {
+#if PLATFORM(IOS_FAMILY)
+    WebThreadLock();
+#endif
+    
     auto* frame = [self _mainCoreFrame];
     if (!frame)
         return nil;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to