Title: [274575] trunk/Source/WebInspectorUI
- Revision
- 274575
- Author
- nvasil...@apple.com
- Date
- 2021-03-17 11:56:31 -0700 (Wed, 17 Mar 2021)
Log Message
Web Inspector: remove experimental setting and enable "grid" badges
https://bugs.webkit.org/show_bug.cgi?id=223209
<rdar://problem/75442185>
Reviewed by BJ Burg.
* UserInterface/Base/Setting.js:
* UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype._updateGridBadge):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (274574 => 274575)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-17 18:56:02 UTC (rev 274574)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-17 18:56:31 UTC (rev 274575)
@@ -1,3 +1,17 @@
+2021-03-17 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: remove experimental setting and enable "grid" badges
+ https://bugs.webkit.org/show_bug.cgi?id=223209
+ <rdar://problem/75442185>
+
+ Reviewed by BJ Burg.
+
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/DOMTreeElement.js:
+ (WI.DOMTreeElement.prototype._updateGridBadge):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
2021-03-15 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: remove experimental setting and enable Layout sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (274574 => 274575)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-03-17 18:56:02 UTC (rev 274574)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-03-17 18:56:31 UTC (rev 274575)
@@ -228,7 +228,6 @@
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", true),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
- experimentalEnableGridBadges: new WI.Setting("experimental-enable-grid-badges", false),
experimentalCollapseBlackboxedCallFrames: new WI.Setting("experimental-collapse-blackboxed-call-frames", false),
// Protocol
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (274574 => 274575)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2021-03-17 18:56:02 UTC (rev 274574)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2021-03-17 18:56:31 UTC (rev 274575)
@@ -2012,9 +2012,6 @@
_updateGridBadge()
{
- if (!WI.settings.experimentalEnableGridBadges.value)
- return;
-
if (!this.listItemElement || this._elementCloseTag)
return;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (274574 => 274575)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-03-17 18:56:02 UTC (rev 274574)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-03-17 18:56:31 UTC (rev 274575)
@@ -398,7 +398,6 @@
let stylesGroup = experimentalSettingsView.addGroup(WI.UIString("Styles:"));
stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToEffective, WI.UIString("Show jump to effective property button"));
stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToVariableDeclaration, WI.UIString("Show jump to variable declaration button"));
- stylesGroup.addSetting(WI.settings.experimentalEnableGridBadges, WI.unlocalizedString("Show \"grid\" badges"));
experimentalSettingsView.addSeparator();
}
@@ -428,7 +427,6 @@
listenForChange(WI.settings.experimentalEnablePreviewFeatures);
if (hasCSSDomain) {
- listenForChange(WI.settings.experimentalEnableGridBadges);
listenForChange(WI.settings.experimentalEnableStylesJumpToEffective);
listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
