Title: [275312] trunk/Source/WebCore
- Revision
- 275312
- Author
- za...@apple.com
- Date
- 2021-03-31 15:36:17 -0700 (Wed, 31 Mar 2021)
Log Message
Remove misleading FIXME comment in RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets
https://bugs.webkit.org/show_bug.cgi?id=224020
Reviewed by Simon Fraser.
RenderStyle should not contain such logic (or any layout related logic for that matter).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275311 => 275312)
--- trunk/Source/WebCore/ChangeLog 2021-03-31 22:32:09 UTC (rev 275311)
+++ trunk/Source/WebCore/ChangeLog 2021-03-31 22:36:17 UTC (rev 275312)
@@ -1,3 +1,15 @@
+2021-03-31 Zalan Bujtas <za...@apple.com>
+
+ Remove misleading FIXME comment in RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets
+ https://bugs.webkit.org/show_bug.cgi?id=224020
+
+ Reviewed by Simon Fraser.
+
+ RenderStyle should not contain such logic (or any layout related logic for that matter).
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets const):
+
2021-03-31 Chris Lord <cl...@igalia.com>
Make FontCache self-contained (remove static global variables)
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (275311 => 275312)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2021-03-31 22:32:09 UTC (rev 275311)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2021-03-31 22:36:17 UTC (rev 275312)
@@ -5130,7 +5130,6 @@
{
if (!isOutOfFlowPositioned())
return false;
- // FIXME: see if this can become a helper on RenderStyle.
if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()))
return true;
return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
