Title: [275829] trunk/Source/WebCore
Revision
275829
Author
wei...@apple.com
Date
2021-04-12 10:37:11 -0700 (Mon, 12 Apr 2021)

Log Message

Remove unused 'DefaultDefineOwnProperty' extended attribute support
https://bugs.webkit.org/show_bug.cgi?id=224436

Reviewed by Antti Koivisto.

The old CSSStyleDeclaration named-getter based implementation was
the last user so this can now be removed.

* bindings/scripts/CodeGeneratorJS.pm:
(InstanceOverridesDefineOwnProperty):
* bindings/scripts/IDLAttributes.json:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (275828 => 275829)


--- trunk/Source/WebCore/ChangeLog	2021-04-12 17:26:35 UTC (rev 275828)
+++ trunk/Source/WebCore/ChangeLog	2021-04-12 17:37:11 UTC (rev 275829)
@@ -1,3 +1,17 @@
+2021-04-12  Sam Weinig  <wei...@apple.com>
+
+        Remove unused 'DefaultDefineOwnProperty' extended attribute support 
+        https://bugs.webkit.org/show_bug.cgi?id=224436
+
+        Reviewed by Antti Koivisto.
+
+        The old CSSStyleDeclaration named-getter based implementation was
+        the last user so this can now be removed.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (InstanceOverridesDefineOwnProperty):
+        * bindings/scripts/IDLAttributes.json:
+
 2021-04-12  Philippe Normand  <pnorm...@igalia.com>
 
         [GStreamer][WebRTC] An audio track should be muted when capture is interrupted by the OS.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (275828 => 275829)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2021-04-12 17:26:35 UTC (rev 275828)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2021-04-12 17:37:11 UTC (rev 275829)
@@ -2185,9 +2185,6 @@
 sub InstanceOverridesDefineOwnProperty
 {
     my $interface = shift;
-
-    return 0 if $interface->extendedAttributes->{DefaultDefineOwnProperty};
-
     return $interface->extendedAttributes->{CustomDefineOwnProperty}
         || GetIndexedSetterOperation($interface)
         || GetNamedSetterOperation($interface);

Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.json (275828 => 275829)


--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2021-04-12 17:26:35 UTC (rev 275828)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.json	2021-04-12 17:37:11 UTC (rev 275829)
@@ -147,9 +147,6 @@
         "Default": {
             "contextsAllowed": ["operation"]
         },
-        "DefaultDefineOwnProperty": {
-            "contextsAllowed": ["interface"]
-        },
         "DelegateToSharedSyntheticAttribute": {
             "contextsAllowed": ["attribute"]
         },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to