Title: [276342] trunk/Source/WebCore
Revision
276342
Author
basuke.suz...@sony.com
Date
2021-04-20 18:42:52 -0700 (Tue, 20 Apr 2021)

Log Message

[clang] Remove implicit cast related warnings.
https://bugs.webkit.org/show_bug.cgi?id=224797

Reviewed by Darin Adler.

Added explicit cast to suppress warning.
Behavior is not changed from implicit cast.

No new tests because there's no behavior change.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (276341 => 276342)


--- trunk/Source/WebCore/ChangeLog	2021-04-21 01:20:17 UTC (rev 276341)
+++ trunk/Source/WebCore/ChangeLog	2021-04-21 01:42:52 UTC (rev 276342)
@@ -1,3 +1,18 @@
+2021-04-20  Basuke Suzuki  <basuke.suz...@sony.com>
+
+        [clang] Remove implicit cast related warnings.
+        https://bugs.webkit.org/show_bug.cgi?id=224797
+
+        Reviewed by Darin Adler.
+
+        Added explicit cast to suppress warning.
+        Behavior is not changed from implicit cast.
+
+        No new tests because there's no behavior change.
+
+        * rendering/RenderBlockFlow.cpp:
+        (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
+
 2021-04-20  Brent Fulgham  <bfulg...@apple.com>
 
         [Cocoa] Prevent GPU and WebContent processes from attempting to connect to the AppSSO service 

Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (276341 => 276342)


--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2021-04-21 01:20:17 UTC (rev 276341)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2021-04-21 01:42:52 UTC (rev 276342)
@@ -1782,8 +1782,8 @@
         // top of the page.
         // FIXME: We are still honoring gigantic margins, which does leave open the possibility of blank pages caused by this heuristic. It remains to be seen whether or not
         // this will be a real-world issue. For now we don't try to deal with this problem.
-        logicalOffset = intMaxForLayoutUnit;
-        logicalBottom = intMinForLayoutUnit;
+        logicalOffset = static_cast<float>(intMaxForLayoutUnit);
+        logicalBottom = static_cast<float>(intMinForLayoutUnit);
         lineBox->computeReplacedAndTextLineTopAndBottom(logicalOffset, logicalBottom);
         lineHeight = logicalBottom - logicalOffset;
         if (logicalOffset == intMaxForLayoutUnit || lineHeight > pageLogicalHeight) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to