Title: [277187] branches/safari-611-branch/Source/WebCore
Revision
277187
Author
repst...@apple.com
Date
2021-05-07 11:48:12 -0700 (Fri, 07 May 2021)

Log Message

Cherry-pick r276492. rdar://problem/77581017

    Do not set synchronous scrolling for layers without relevant scrolling scopes
    https://bugs.webkit.org/show_bug.cgi?id=221383

    Reviewed by Simon Fraser.

    Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
    to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
    in RenderLayer::updateLayerPosition.

    * rendering/RenderLayerCompositor.cpp:
    (WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
    setSynchronousScrollingReasons() if there is no scrollingScope.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (277186 => 277187)


--- branches/safari-611-branch/Source/WebCore/ChangeLog	2021-05-07 18:48:08 UTC (rev 277186)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog	2021-05-07 18:48:12 UTC (rev 277187)
@@ -1,5 +1,39 @@
 2021-05-06  Russell Epstein  <repst...@apple.com>
 
+        Cherry-pick r276492. rdar://problem/77581017
+
+    Do not set synchronous scrolling for layers without relevant scrolling scopes
+    https://bugs.webkit.org/show_bug.cgi?id=221383
+    
+    Reviewed by Simon Fraser.
+    
+    Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
+    to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
+    in RenderLayer::updateLayerPosition.
+    
+    * rendering/RenderLayerCompositor.cpp:
+    (WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
+    setSynchronousScrollingReasons() if there is no scrollingScope.
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-04-22  Sergio Villar Senin  <svil...@igalia.com>
+
+            Do not set synchronous scrolling for layers without relevant scrolling scopes
+            https://bugs.webkit.org/show_bug.cgi?id=221383
+
+            Reviewed by Simon Fraser.
+
+            Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
+            to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
+            in RenderLayer::updateLayerPosition.
+
+            * rendering/RenderLayerCompositor.cpp:
+            (WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
+            setSynchronousScrollingReasons() if there is no scrollingScope.
+
+2021-05-06  Russell Epstein  <repst...@apple.com>
+
         Cherry-pick r275938. rdar://problem/77581120
 
     Do not reset computed style for element children with display contents style

Modified: branches/safari-611-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp (277186 => 277187)


--- branches/safari-611-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp	2021-05-07 18:48:08 UTC (rev 277186)
+++ branches/safari-611-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp	2021-05-07 18:48:12 UTC (rev 277187)
@@ -4868,8 +4868,7 @@
         if (!layer)
             continue;
 
-        auto scrollingScope = relevantScrollingScope(renderer, *layer);
-        if (scrollingScope != rootScrollingScope) {
+        if (auto scrollingScope = relevantScrollingScope(renderer, *layer); scrollingScope && scrollingScope != rootScrollingScope) {
             auto enclosingScrollingNodeID = asyncScrollableContainerNodeID(renderer);
             ASSERT(enclosingScrollingNodeID);
             
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to