Title: [277429] trunk/Tools
- Revision
- 277429
- Author
- timothy_hor...@apple.com
- Date
- 2021-05-13 03:39:13 -0700 (Thu, 13 May 2021)
Log Message
ResizeReversePaginatedWebView fails on some OS versions on some hardware
https://bugs.webkit.org/show_bug.cgi?id=224699
<rdar://76782199>
Reviewed by Megan Gardner.
* TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
This test does *not* care about the specific number of pages that are
generated; the key to the test is the scroll position check.
Since the page-count check in this test has caused lots of trouble
in the past (see the history) just remove it and replace it with a
check that we ended up paginated at all.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (277428 => 277429)
--- trunk/Tools/ChangeLog 2021-05-13 09:53:20 UTC (rev 277428)
+++ trunk/Tools/ChangeLog 2021-05-13 10:39:13 UTC (rev 277429)
@@ -1,3 +1,20 @@
+2021-05-13 Tim Horton <timothy_hor...@apple.com>
+
+ ResizeReversePaginatedWebView fails on some OS versions on some hardware
+ https://bugs.webkit.org/show_bug.cgi?id=224699
+ <rdar://76782199>
+
+ Reviewed by Megan Gardner.
+
+ * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
+ (TestWebKitAPI::didLayout):
+ This test does *not* care about the specific number of pages that are
+ generated; the key to the test is the scroll position check.
+
+ Since the page-count check in this test has caused lots of trouble
+ in the past (see the history) just remove it and replace it with a
+ check that we ended up paginated at all.
+
2021-05-12 Simon Fraser <simon.fra...@apple.com>
Update the MotionMark 1.1 plan file
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp (277428 => 277429)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp 2021-05-13 09:53:20 UTC (rev 277428)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp 2021-05-13 10:39:13 UTC (rev 277429)
@@ -42,7 +42,6 @@
static const unsigned pageLength = 100;
static const unsigned pageGap = 100;
-static const unsigned expectedPageCount = 49;
static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
{
@@ -50,7 +49,7 @@
PlatformWebView* webView = (PlatformWebView*)clientInfo;
unsigned pageCount = WKPageGetPageCount(page);
- EXPECT_EQ(expectedPageCount, pageCount);
+ EXPECT_GT(pageCount, 2U);
webView->resizeTo((pageLength * pageCount) + (pageGap * (pageCount - 1)), 500);
EXPECT_JS_EQ(page, "window.scrollX", "0");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
