Title: [277873] trunk/Source/WebKit
Revision
277873
Author
mmaxfi...@apple.com
Date
2021-05-21 11:54:57 -0700 (Fri, 21 May 2021)

Log Message

[Cocoa] REGRESSION(Sandbox): Font smoothing within Safari doesn't seem to respect AppleFontSmoothing
https://bugs.webkit.org/show_bug.cgi?id=226066
<rdar://problem/72795817>

Reviewed by Per Arne Vollan.

We accidentally blocked access to the relevant defaults database.

It turns out this is untestable. I can't use the actual functionality without actually setting the preference
for the whole user (and all their apps). And, I can't use sandbox_check() to make sure the file is readable
because it's in the user's home directory, so the path to check will be different for every user.

* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (277872 => 277873)


--- trunk/Source/WebKit/ChangeLog	2021-05-21 18:24:50 UTC (rev 277872)
+++ trunk/Source/WebKit/ChangeLog	2021-05-21 18:54:57 UTC (rev 277873)
@@ -1,3 +1,19 @@
+2021-05-21  Myles C. Maxfield  <mmaxfi...@apple.com>
+
+        [Cocoa] REGRESSION(Sandbox): Font smoothing within Safari doesn't seem to respect AppleFontSmoothing
+        https://bugs.webkit.org/show_bug.cgi?id=226066
+        <rdar://problem/72795817>
+
+        Reviewed by Per Arne Vollan.
+
+        We accidentally blocked access to the relevant defaults database.
+
+        It turns out this is untestable. I can't use the actual functionality without actually setting the preference
+        for the whole user (and all their apps). And, I can't use sandbox_check() to make sure the file is readable
+        because it's in the user's home directory, so the path to check will be different for every user.
+
+        * WebProcess/com.apple.WebProcess.sb.in:
+
 2021-05-21  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [iOS] Plumb element bounds when presenting QLPreviewController for image extraction

Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (277872 => 277873)


--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-05-21 18:24:50 UTC (rev 277872)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2021-05-21 18:54:57 UTC (rev 277873)
@@ -1027,6 +1027,7 @@
     (home-subpath "/Library/Preferences/com.apple.universalaccess.plist")
     (home-subpath "/Library/Preferences/edu.mit.Kerberos.plist")
     (home-subpath "/Library/Preferences/pbs.plist")
+    (home-regex "/Library/Preferences/ByHost/\.GlobalPreferences\..*\.plist$")
 )
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to