Title: [279825] trunk
- Revision
- 279825
- Author
- clo...@igalia.com
- Date
- 2021-07-12 06:05:40 -0700 (Mon, 12 Jul 2021)
Log Message
Unreviewed, reverting r279778.
It caused unexpected text diffs on http/tests/storageAccess
tests
Reverted changeset:
"[GTK][WPE][libsoup] Test imported/w3c/web-platform-
tests/cookies/samesite/about-blank-toplevel.https.html crashes
since it was imported"
https://bugs.webkit.org/show_bug.cgi?id=227819
https://commits.webkit.org/r279778
Modified Paths
Removed Paths
- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/
Diff
Modified: trunk/LayoutTests/ChangeLog (279824 => 279825)
--- trunk/LayoutTests/ChangeLog 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/LayoutTests/ChangeLog 2021-07-12 13:05:40 UTC (rev 279825)
@@ -1,3 +1,18 @@
+2021-07-12 Carlos Alberto Lopez Perez <clo...@igalia.com>
+
+ Unreviewed, reverting r279778.
+
+ It caused unexpected text diffs on http/tests/storageAccess
+ tests
+
+ Reverted changeset:
+
+ "[GTK][WPE][libsoup] Test imported/w3c/web-platform-
+ tests/cookies/samesite/about-blank-toplevel.https.html crashes
+ since it was imported"
+ https://bugs.webkit.org/show_bug.cgi?id=227819
+ https://commits.webkit.org/r279778
+
2021-07-12 Rob Buis <rb...@igalia.com>
Resync web-platform-tests/css/css-overflow from upstream
Modified: trunk/LayoutTests/platform/glib/TestExpectations (279824 => 279825)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-12 13:05:40 UTC (rev 279825)
@@ -270,8 +270,6 @@
imported/w3c/web-platform-tests/fetch/http-cache/basic-auth-cache-test.html [ Pass ]
-imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Pass ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of PASSING tests.
#////////////////////////////////////////////////////////////////////////////////////////
@@ -2324,6 +2322,8 @@
webkit.org/b/227665 fast/css/parsing-relative-color-syntax.html [ Failure ]
+webkit.org/b/227819 imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Crash ]
+
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.html [ Failure ]
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.https.html [ Failure ]
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.header.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (279824 => 279825)
--- trunk/Source/WebCore/ChangeLog 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/Source/WebCore/ChangeLog 2021-07-12 13:05:40 UTC (rev 279825)
@@ -1,3 +1,18 @@
+2021-07-12 Carlos Alberto Lopez Perez <clo...@igalia.com>
+
+ Unreviewed, reverting r279778.
+
+ It caused unexpected text diffs on http/tests/storageAccess
+ tests
+
+ Reverted changeset:
+
+ "[GTK][WPE][libsoup] Test imported/w3c/web-platform-
+ tests/cookies/samesite/about-blank-toplevel.https.html crashes
+ since it was imported"
+ https://bugs.webkit.org/show_bug.cgi?id=227819
+ https://commits.webkit.org/r279778
+
2021-07-12 Alexander Mikhaylenko <al...@gnome.org>
[GTK][WPE] Match Adwaita scrollbars more closely
Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (279824 => 279825)
--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2021-07-12 13:05:40 UTC (rev 279825)
@@ -552,9 +552,6 @@
return false;
auto cookieURI = sameSiteInfo.isSameSite ? urlToSoupURI(url) : nullptr;
- if (!cookieURI)
- return false;
-
GUniquePtr<GSList> cookies(soup_cookie_jar_get_cookie_list_with_same_site_info(cookieStorage(), uri.get(), firstPartyURI.get(), cookieURI.get(), TRUE, sameSiteInfo.isSafeHTTPMethod, sameSiteInfo.isTopSite));
#else
GUniquePtr<GSList> cookies(soup_cookie_jar_get_cookie_list(cookieStorage(), uri.get(), TRUE));
@@ -595,9 +592,6 @@
return { { }, false };
auto cookieURI = sameSiteInfo.isSameSite ? urlToSoupURI(url) : nullptr;
- if (!cookieURI)
- return { { }, false };
-
GSList* cookies = soup_cookie_jar_get_cookie_list_with_same_site_info(session.cookieStorage(), uri.get(), firstPartyURI.get(), cookieURI.get(), forHTTPHeader, sameSiteInfo.isSafeHTTPMethod, sameSiteInfo.isTopSite);
#else
GSList* cookies = soup_cookie_jar_get_cookie_list(session.cookieStorage(), uri.get(), forHTTPHeader);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
