Title: [280439] trunk/Tools
Revision
280439
Author
peng.l...@apple.com
Date
2021-07-29 12:04:52 -0700 (Thu, 29 Jul 2021)

Log Message

[Catalina][GPUP] Some API tests fail after GPU Process features are enabled
https://bugs.webkit.org/show_bug.cgi?id=228589

Reviewed by Aakash Jain.

Disable a few API tests while the investigation is ongoing.

* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
* TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
(TEST_F):
* TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
(TEST_F):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (280438 => 280439)


--- trunk/Tools/ChangeLog	2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/ChangeLog	2021-07-29 19:04:52 UTC (rev 280439)
@@ -1,3 +1,20 @@
+2021-07-29  Peng Liu  <peng.l...@apple.com>
+
+        [Catalina][GPUP] Some API tests fail after GPU Process features are enabled
+        https://bugs.webkit.org/show_bug.cgi?id=228589
+
+        Reviewed by Aakash Jain.
+
+        Disable a few API tests while the investigation is ongoing.
+
+        * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+        * TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
+        (TEST_F):
+        * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
+        (TEST_F):
+
 2021-07-29  Aakash Jain  <aakash_j...@apple.com>
 
         Send email notification when VerifyGitHubIntegrity step fails

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (280438 => 280439)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm	2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm	2021-07-29 19:04:52 UTC (rev 280439)
@@ -648,7 +648,7 @@
     EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
 }
 
-TEST(WebKit2, CrashGPUProcessAfterApplyingConstraints)
+TEST(WebKit2, DISABLED_CrashGPUProcessAfterApplyingConstraints)
 {
     auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
     auto preferences = [configuration preferences];

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm (280438 => 280439)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm	2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AudioBufferSize.mm	2021-07-29 19:04:52 UTC (rev 280439)
@@ -56,7 +56,7 @@
     return 0;
 }
 
-TEST(WebKit, AudioBufferSize)
+TEST(WebKit, DISABLED_AudioBufferSize)
 {
     auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
     auto context = adoptWK(TestWebKitAPI::Util::createContextForInjectedBundleTest("InternalsInjectedBundleTest"));

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm (280438 => 280439)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm	2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm	2021-07-29 19:04:52 UTC (rev 280439)
@@ -203,7 +203,7 @@
     HashMap<CFNotificationName, NotificationCallback> _callbacks;
 };
 
-TEST_F(NowPlayingTest, AudioElement)
+TEST_F(NowPlayingTest, DISABLED_AudioElement)
 {
     executeAndWaitForWebViewToBecomeNowPlaying([&] {
         executeAndWaitForPlaying([&] {
@@ -214,7 +214,7 @@
     });
 }
 
-TEST_F(NowPlayingTest, VideoElementWithAudio)
+TEST_F(NowPlayingTest, DISABLED_VideoElementWithAudio)
 {
     executeAndWaitForWebViewToBecomeNowPlaying([&] {
         executeAndWaitForPlaying([&] {
@@ -246,7 +246,7 @@
     ASSERT_NE(webViewPid(), getNowPlayingClientPid());
 }
 
-TEST_F(NowPlayingTest, VideoElementWithMutedAudioUnmutedWithUserGesture)
+TEST_F(NowPlayingTest, DISABLED_VideoElementWithMutedAudioUnmutedWithUserGesture)
 {
     executeAndWaitForPlaying([&] {
         loadPage("now-playing");

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm (280438 => 280439)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm	2021-07-29 18:58:04 UTC (rev 280438)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm	2021-07-29 19:04:52 UTC (rev 280439)
@@ -79,32 +79,32 @@
     EXPECT_EQ(512, preferredAudioBufferSize());
 }
 
-TEST_F(PreferredAudioBufferSize, AudioElement)
+TEST_F(PreferredAudioBufferSize, DISABLED_AudioElement)
 {
     runPlayingTestWithPageNamed(@"audio-only", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, WebAudio)
+TEST_F(PreferredAudioBufferSize, DISABLED_WebAudio)
 {
     runPlayingTestWithPageNamed(@"web-audio-only", 128);
 }
 
-TEST_F(PreferredAudioBufferSize, VideoOnly)
+TEST_F(PreferredAudioBufferSize, DISABLED_VideoOnly)
 {
     runPlayingTestWithPageNamed(@"video-without-audio", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, VideoWithAudio)
+TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudio)
 {
     runPlayingTestWithPageNamed(@"video-with-audio", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, AudioWithWebAudio)
+TEST_F(PreferredAudioBufferSize, DISABLED_AudioWithWebAudio)
 {
     runPlayingTestWithPageNamed(@"audio-with-web-audio", 128);
 }
 
-TEST_F(PreferredAudioBufferSize, VideoWithAudioAndWebAudio)
+TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudioAndWebAudio)
 {
     runPlayingTestWithPageNamed(@"video-with-audio-and-web-audio", 128);
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to