Title: [280742] trunk/Source/WebCore
- Revision
- 280742
- Author
- al...@gnome.org
- Date
- 2021-08-06 16:14:55 -0700 (Fri, 06 Aug 2021)
Log Message
REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures
https://bugs.webkit.org/show_bug.cgi?id=228160
Reviewed by Michael Catanzaro.
Normally adjustText*() are only called for unstyled elements to adjust their platform
appearance, However, for entries we always call it since
https://bugs.webkit.org/show_bug.cgi?id=173572 and it causes problems.
That change was done for RenderThemeGtk and is not relevant anymore, so we can revert
it.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (280741 => 280742)
--- trunk/Source/WebCore/ChangeLog 2021-08-06 23:11:01 UTC (rev 280741)
+++ trunk/Source/WebCore/ChangeLog 2021-08-06 23:14:55 UTC (rev 280742)
@@ -1,3 +1,20 @@
+2021-08-06 Alexander Mikhaylenko <al...@gnome.org>
+
+ REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures
+ https://bugs.webkit.org/show_bug.cgi?id=228160
+
+ Reviewed by Michael Catanzaro.
+
+ Normally adjustText*() are only called for unstyled elements to adjust their platform
+ appearance, However, for entries we always call it since
+ https://bugs.webkit.org/show_bug.cgi?id=173572 and it causes problems.
+
+ That change was done for RenderThemeGtk and is not relevant anymore, so we can revert
+ it.
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+
2021-08-06 Youenn Fablet <you...@apple.com>
[GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (280741 => 280742)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2021-08-06 23:11:01 UTC (rev 280741)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2021-08-06 23:14:55 UTC (rev 280742)
@@ -93,9 +93,6 @@
style.setAppearance(MenulistButtonPart);
part = MenulistButtonPart;
break;
- case TextFieldPart:
- adjustTextFieldStyle(style, element);
- FALLTHROUGH;
default:
style.setAppearance(NoControlPart);
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes