Title: [281013] trunk/Source/WebCore
- Revision
- 281013
- Author
- j...@apple.com
- Date
- 2021-08-13 04:57:19 -0700 (Fri, 13 Aug 2021)
Log Message
nexttrack and previoustrack MediaSession handlers not working
https://bugs.webkit.org/show_bug.cgi?id=229068
rdar://80100092
Reviewed by Youenn Fablet.
Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
were inverted.
There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
used with the MediaRemote backend, which prevents automating the test.
* Modules/mediasession/MediaSession.cpp:
(WebCore::platformCommandForMediaSessionAction):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281012 => 281013)
--- trunk/Source/WebCore/ChangeLog 2021-08-13 10:22:38 UTC (rev 281012)
+++ trunk/Source/WebCore/ChangeLog 2021-08-13 11:57:19 UTC (rev 281013)
@@ -1,3 +1,19 @@
+2021-08-13 Jean-Yves Avenard <j...@apple.com>
+
+ nexttrack and previoustrack MediaSession handlers not working
+ https://bugs.webkit.org/show_bug.cgi?id=229068
+ rdar://80100092
+
+ Reviewed by Youenn Fablet.
+
+ Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
+ were inverted.
+ There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
+ used with the MediaRemote backend, which prevents automating the test.
+
+ * Modules/mediasession/MediaSession.cpp:
+ (WebCore::platformCommandForMediaSessionAction):
+
2021-08-13 Youenn Fablet <you...@apple.com>
Overly verbose catchable fetch error messages lead to cross-origin leaks
Modified: trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp (281012 => 281013)
--- trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp 2021-08-13 10:22:38 UTC (rev 281012)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp 2021-08-13 11:57:19 UTC (rev 281013)
@@ -64,8 +64,8 @@
{ MediaSessionAction::Pause, PlatformMediaSession::PauseCommand },
{ MediaSessionAction::Seekforward, PlatformMediaSession::SkipForwardCommand },
{ MediaSessionAction::Seekbackward, PlatformMediaSession::SkipBackwardCommand },
- { MediaSessionAction::Previoustrack, PlatformMediaSession::NextTrackCommand },
- { MediaSessionAction::Nexttrack, PlatformMediaSession::PreviousTrackCommand },
+ { MediaSessionAction::Previoustrack, PlatformMediaSession::PreviousTrackCommand },
+ { MediaSessionAction::Nexttrack, PlatformMediaSession::NextTrackCommand },
{ MediaSessionAction::Stop, PlatformMediaSession::StopCommand },
{ MediaSessionAction::Seekto, PlatformMediaSession::SeekToPlaybackPositionCommand },
{ MediaSessionAction::Skipad, PlatformMediaSession::NextTrackCommand },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
