Title: [281201] trunk/Source/WebKit
- Revision
- 281201
- Author
- you...@apple.com
- Date
- 2021-08-18 11:04:09 -0700 (Wed, 18 Aug 2021)
Log Message
[MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=229238
Reviewed by Eric Carlson.
Manually tested.
* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (281200 => 281201)
--- trunk/Source/WebKit/ChangeLog 2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/ChangeLog 2021-08-18 18:04:09 UTC (rev 281201)
@@ -1,3 +1,18 @@
+2021-08-18 Youenn Fablet <you...@apple.com>
+
+ [MacOS] Use com.apple.webkit.microphone extension to gate microphone access in GPUProcess sandbox
+ https://bugs.webkit.org/show_bug.cgi?id=229238
+
+ Reviewed by Eric Carlson.
+
+ Manually tested.
+
+ * GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+ Align to iOS and only allow microphone access in sandbox if com.apple.webkit.microphone is sent to GPUProcess.
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+ Do audio capture in UIProcess for non Safari applications until rdar://problem/29448368 is fixed.
+
2021-08-18 Sihui Liu <sihui_...@apple.com>
Do not terminate relaunched network process when getting network process connection
Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (281200 => 281201)
--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2021-08-18 18:04:09 UTC (rev 281201)
@@ -933,8 +933,8 @@
domains))
;; Media capture, microphone access
-;; FIXME: make device-microphone access gated by the "com.apple.webkit.microphone" extension.
-(allow device-microphone)
+(with-filter (extension "com.apple.webkit.microphone")
+ (allow device-microphone))
;; Media capture, camera access
(with-filter (extension "com.apple.webkit.camera")
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (281200 => 281201)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-08-18 17:57:24 UTC (rev 281200)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-08-18 18:04:09 UTC (rev 281201)
@@ -190,6 +190,12 @@
bool defaultCaptureAudioInGPUProcessEnabled()
{
+#if PLATFORM(MAC)
+ // FIXME: Enable GPU process audio capture when <rdar://problem/29448368> is fixed.
+ if (!WebCore::MacApplication::isSafari())
+ return false;
+#endif
+
#if ENABLE(GPU_PROCESS_BY_DEFAULT)
bool defaultValue = true;
#else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
