Title: [281223] trunk/Source/WebCore
- Revision
- 281223
- Author
- ddkil...@apple.com
- Date
- 2021-08-18 21:04:19 -0700 (Wed, 18 Aug 2021)
Log Message
Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process
<https://webkit.org/b/229264>
<rdar://problem/82101153>
Reviewed by Anders Carlsson.
Covered by running layout tests with --leaks plus future patch
to check for leaks in the GPU process.
* platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::initialize):
- Use adoptCF() to fix the leak since CMBufferQueueCreate()
returns a retained object.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281222 => 281223)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 03:42:16 UTC (rev 281222)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 04:04:19 UTC (rev 281223)
@@ -1,5 +1,21 @@
2021-08-18 David Kilzer <ddkil...@apple.com>
+ Bug 229264: Leak of CMBufferQueueRef (up to 752 bytes each) in com.apple.WebKit.GPU.Development process
+ <https://webkit.org/b/229264>
+ <rdar://problem/82101153>
+
+ Reviewed by Anders Carlsson.
+
+ Covered by running layout tests with --leaks plus future patch
+ to check for leaks in the GPU process.
+
+ * platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
+ (WebCore::VideoSampleBufferCompressor::initialize):
+ - Use adoptCF() to fix the leak since CMBufferQueueCreate()
+ returns a retained object.
+
+2021-08-18 David Kilzer <ddkil...@apple.com>
+
Leak of CMSampleBufferRef (up to 2.25 KB each) in com.apple.WebKit.GPU.Development process
<https://webkit.org/b/229262>
<rdar://problem/82076765>
Modified: trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm (281222 => 281223)
--- trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm 2021-08-19 03:42:16 UTC (rev 281222)
+++ trunk/Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm 2021-08-19 04:04:19 UTC (rev 281223)
@@ -80,7 +80,7 @@
RELEASE_LOG_ERROR(MediaStream, "VideoSampleBufferCompressor unable to create buffer queue %d", error);
return false;
}
- m_outputBufferQueue = outputBufferQueue;
+ m_outputBufferQueue = adoptCF(outputBufferQueue);
PAL::CMBufferQueueInstallTrigger(m_outputBufferQueue.get(), callback, callbackObject, kCMBufferQueueTrigger_WhenDataBecomesReady, PAL::kCMTimeZero, NULL);
m_isEncoding = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
