Title: [281226] trunk/Source/WebCore
- Revision
- 281226
- Author
- you...@apple.com
- Date
- 2021-08-19 01:22:22 -0700 (Thu, 19 Aug 2021)
Log Message
RTCRtpTransceiver does not need an ice transport
https://bugs.webkit.org/show_bug.cgi?id=229186
Reviewed by Eric Carlson.
No change of behavior, we are removing a member from RTCRtpTransceiver which is unused.
We are also updating RTCIceTransport as it does not need to have virtual methods yet.
* Modules/mediastream/RTCIceTransport.cpp:
(WebCore::RTCIceTransport::~RTCIceTransport):
* Modules/mediastream/RTCIceTransport.h:
* Modules/mediastream/RTCIceTransport.idl:
* Modules/mediastream/RTCRtpTransceiver.cpp:
(WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
* Modules/mediastream/RTCRtpTransceiver.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (281225 => 281226)
--- trunk/Source/WebCore/ChangeLog 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/ChangeLog 2021-08-19 08:22:22 UTC (rev 281226)
@@ -1,5 +1,23 @@
2021-08-19 Youenn Fablet <you...@apple.com>
+ RTCRtpTransceiver does not need an ice transport
+ https://bugs.webkit.org/show_bug.cgi?id=229186
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior, we are removing a member from RTCRtpTransceiver which is unused.
+ We are also updating RTCIceTransport as it does not need to have virtual methods yet.
+
+ * Modules/mediastream/RTCIceTransport.cpp:
+ (WebCore::RTCIceTransport::~RTCIceTransport):
+ * Modules/mediastream/RTCIceTransport.h:
+ * Modules/mediastream/RTCIceTransport.idl:
+ * Modules/mediastream/RTCRtpTransceiver.cpp:
+ (WebCore::RTCRtpTransceiver::RTCRtpTransceiver):
+ * Modules/mediastream/RTCRtpTransceiver.h:
+
+2021-08-19 Youenn Fablet <you...@apple.com>
+
Add support for RTCDtlsTransport
https://bugs.webkit.org/show_bug.cgi?id=229133
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp (281225 => 281226)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.cpp 2021-08-19 08:22:22 UTC (rev 281226)
@@ -34,6 +34,10 @@
WTF_MAKE_ISO_ALLOCATED_IMPL(RTCIceTransport);
+RTCIceTransport::~RTCIceTransport()
+{
+}
+
} // namespace WebCore
#endif // ENABLE(WEB_RTC)
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h (281225 => 281226)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.h 2021-08-19 08:22:22 UTC (rev 281226)
@@ -41,7 +41,7 @@
namespace WebCore {
-class RTCIceTransport final : public RefCounted<RTCIceTransport>, public ScriptWrappable {
+class RTCIceTransport : public RefCounted<RTCIceTransport>, public ScriptWrappable {
WTF_MAKE_ISO_ALLOCATED(RTCIceTransport);
public:
static Ref<RTCIceTransport> create()
@@ -48,7 +48,7 @@
{
return adoptRef(*new RTCIceTransport());
}
- virtual ~RTCIceTransport() = default;
+ ~RTCIceTransport();
RTCIceTransportState state() const { return m_transportState; }
void setState(RTCIceTransportState state) { m_transportState = state; }
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl (281225 => 281226)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceTransport.idl 2021-08-19 08:22:22 UTC (rev 281226)
@@ -29,7 +29,8 @@
[
Conditional=WEB_RTC,
EnabledBySetting=PeerConnection,
- Exposed=Window
+ Exposed=Window,
+ SkipVTableValidation
] interface RTCIceTransport {
// FIXME 169662: missing readonly attribute RTCIceRole role;
// FIXME 169662: missing readonly attribute RTCIceComponent component;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp (281225 => 281226)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp 2021-08-19 08:22:22 UTC (rev 281226)
@@ -46,7 +46,6 @@
: m_direction(RTCRtpTransceiverDirection::Sendrecv)
, m_sender(WTFMove(sender))
, m_receiver(WTFMove(receiver))
- , m_iceTransport(RTCIceTransport::create())
, m_backend(WTFMove(backend))
{
}
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h (281225 => 281226)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h 2021-08-19 07:36:49 UTC (rev 281225)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h 2021-08-19 08:22:22 UTC (rev 281226)
@@ -33,7 +33,6 @@
#if ENABLE(WEB_RTC)
-#include "RTCIceTransport.h"
#include "RTCRtpReceiver.h"
#include "RTCRtpSender.h"
#include "RTCRtpTransceiverBackend.h"
@@ -70,11 +69,6 @@
ExceptionOr<void> stop();
ExceptionOr<void> setCodecPreferences(const Vector<RTCRtpCodecCapability>&);
- // FIXME: Temporary solution to keep track of ICE states for this transceiver. Later, each
- // sender and receiver will have up to two DTLS transports, which in turn will have an ICE
- // transport each.
- RTCIceTransport& iceTransport() { return m_iceTransport.get(); }
-
RTCRtpTransceiverBackend* backend() { return m_backend.get(); }
void setConnection(RTCPeerConnection&);
@@ -88,7 +82,6 @@
bool m_stopped { false };
- Ref<RTCIceTransport> m_iceTransport;
std::unique_ptr<RTCRtpTransceiverBackend> m_backend;
WeakPtr<RTCPeerConnection> m_connection;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
