[webkit-changes] [281247] trunk/Source

Thu, 19 Aug 2021 09:38:56 -0700

Title: [281247] trunk/Source
Revision
281247
Author
simon.fra...@apple.com
Date
2021-08-19 09:38:07 -0700 (Thu, 19 Aug 2021)

Log Message

Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously
https://bugs.webkit.org/show_bug.cgi?id=229256

Reviewed by Geoffrey Garen.

Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent()
to scheduleScrollEvent() since the event dispatch happens via the next rendering update.

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::scheduleScrollEvent):
(WebCore::EventHandler::sendScrollEvent): Deleted.
* page/EventHandler.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::scheduleScrollEvent):
(WebCore::FrameView::sendScrollEvent): Deleted.
* page/FrameView.h:

Source/WebKitLegacy/mac:

* WebView/WebFrame.mm:
(-[WebFrame sendScrollEvent]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281246 => 281247)


--- trunk/Source/WebCore/ChangeLog	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/ChangeLog	2021-08-19 16:38:07 UTC (rev 281247)
@@ -1,3 +1,24 @@
+2021-08-19  Simon Fraser  <simon.fra...@apple.com>
+
+        Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously
+        https://bugs.webkit.org/show_bug.cgi?id=229256
+
+        Reviewed by Geoffrey Garen.
+
+        Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent()
+        to scheduleScrollEvent() since the event dispatch happens via the next rendering update.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::scheduleScrollEvent):
+        (WebCore::EventHandler::sendScrollEvent): Deleted.
+        * page/EventHandler.h:
+        * page/FrameView.cpp:
+        (WebCore::FrameView::FrameView):
+        (WebCore::FrameView::scrollPositionChanged):
+        (WebCore::FrameView::scheduleScrollEvent):
+        (WebCore::FrameView::sendScrollEvent): Deleted.
+        * page/FrameView.h:
+
 2021-08-19  Kyle Piddington  <kpidding...@apple.com>
 
         WebGL via Metal experimental feature does not correctly toggle metal backend

Modified: trunk/Source/WebCore/page/EventHandler.cpp (281246 => 281247)


--- trunk/Source/WebCore/page/EventHandler.cpp	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2021-08-19 16:38:07 UTC (rev 281247)
@@ -4362,7 +4362,7 @@
         event.setDefaultHandled();
 }
 
-void EventHandler::sendScrollEvent()
+void EventHandler::scheduleScrollEvent()
 {
     Ref<Frame> protectedFrame(m_frame);
     setFrameWasScrolledByUser();

Modified: trunk/Source/WebCore/page/EventHandler.h (281246 => 281247)


--- trunk/Source/WebCore/page/EventHandler.h	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/EventHandler.h	2021-08-19 16:38:07 UTC (rev 281247)
@@ -280,7 +280,7 @@
 
     void focusDocumentView();
     
-    WEBCORE_EXPORT void sendScrollEvent();
+    WEBCORE_EXPORT void scheduleScrollEvent();
 
 #if PLATFORM(MAC)
     WEBCORE_EXPORT void mouseDown(NSEvent *, NSEvent *correspondingPressureEvent);

Modified: trunk/Source/WebCore/page/FrameView.cpp (281246 => 281247)


--- trunk/Source/WebCore/page/FrameView.cpp	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/FrameView.cpp	2021-08-19 16:38:07 UTC (rev 281247)
@@ -187,7 +187,7 @@
     , m_layoutContext(*this)
     , m_updateEmbeddedObjectsTimer(*this, &FrameView::updateEmbeddedObjectsTimerFired)
     , m_updateWidgetPositionsTimer(*this, &FrameView::updateWidgetPositionsTimerFired)
-    , m_delayedScrollEventTimer(*this, &FrameView::sendScrollEvent)
+    , m_delayedScrollEventTimer(*this, &FrameView::scheduleScrollEvent)
     , m_delayedScrollToFocusedElementTimer(*this, &FrameView::scrollToFocusedElementTimerFired)
     , m_speculativeTilingEnableTimer(*this, &FrameView::speculativeTilingEnableTimerFired)
 {
@@ -2504,7 +2504,7 @@
 
     if (throttlingDelay == 0_s) {
         m_delayedScrollEventTimer.stop();
-        sendScrollEvent();
+        scheduleScrollEvent();
     } else if (!m_delayedScrollEventTimer.isActive())
         m_delayedScrollEventTimer.startOneShot(throttlingDelay);
 
@@ -5110,9 +5110,9 @@
         scrollingCoordinator->frameViewEventTrackingRegionsChanged(*this);
 }
 
-void FrameView::sendScrollEvent()
+void FrameView::scheduleScrollEvent()
 {
-    frame().eventHandler().sendScrollEvent();
+    frame().eventHandler().scheduleScrollEvent();
     frame().eventHandler().dispatchFakeMouseMoveEventSoon();
 }

Modified: trunk/Source/WebCore/page/FrameView.h (281246 => 281247)


--- trunk/Source/WebCore/page/FrameView.h	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebCore/page/FrameView.h	2021-08-19 16:38:07 UTC (rev 281247)
@@ -811,7 +811,7 @@
     void scrollToAnchor();
     void scrollPositionChanged(const ScrollPosition& oldPosition, const ScrollPosition& newPosition);
     void scrollableAreaSetChanged();
-    void sendScrollEvent();
+    void scheduleScrollEvent();
     void resetScrollAnchor();
 
     bool hasCustomScrollbars() const;

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (281246 => 281247)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-08-19 16:38:07 UTC (rev 281247)
@@ -1,3 +1,16 @@
+2021-08-19  Simon Fraser  <simon.fra...@apple.com>
+
+        Rename EventHandler::sendScrollEvent() to scheduleScrollEvent() since the event is not sent synchronously
+        https://bugs.webkit.org/show_bug.cgi?id=229256
+
+        Reviewed by Geoffrey Garen.
+
+        Rename EventHandler::sendScrollEvent() and FrameView::sendScrollEvent()
+        to scheduleScrollEvent() since the event dispatch happens via the next rendering update.
+
+        * WebView/WebFrame.mm:
+        (-[WebFrame sendScrollEvent]):
+
 2021-08-16  David Kilzer  <ddkil...@apple.com>
 
         "make analyze" should run clang static analyzer in deep mode

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm (281246 => 281247)


--- trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm	2021-08-19 16:32:22 UTC (rev 281246)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm	2021-08-19 16:38:07 UTC (rev 281247)
@@ -1832,7 +1832,7 @@
 - (void)sendScrollEvent
 {
     ASSERT(WebThreadIsLockedOrDisabled());
-    _private->coreFrame->eventHandler().sendScrollEvent();
+    _private->coreFrame->eventHandler().scheduleScrollEvent();
 }
 
 - (void)_userScrolled

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to