Title: [281303] releases/WebKitGTK/webkit-2.32/Source/WebCore
- Revision
- 281303
- Author
- ape...@igalia.com
- Date
- 2021-08-20 02:19:45 -0700 (Fri, 20 Aug 2021)
Log Message
Merge r275168 - Make a Ref to HTMLPlugInElement when resolving callback
https://bugs.webkit.org/show_bug.cgi?id=223846
Patch by Ian Gilbert <i...@apple.com> on 2021-03-29
Reviewed by Ryosuke Niwa.
Take a Ref to the HTMLPlugInElement to keep it alive while invoking HTMLPlugInElement::swapRendererTimerFired()
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::swapRendererTimerFired):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (281302 => 281303)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-08-20 09:18:31 UTC (rev 281302)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-08-20 09:19:45 UTC (rev 281303)
@@ -1,3 +1,15 @@
+2021-03-29 Ian Gilbert <i...@apple.com>
+
+ Make a Ref to HTMLPlugInElement when resolving callback
+ https://bugs.webkit.org/show_bug.cgi?id=223846
+
+ Reviewed by Ryosuke Niwa.
+
+ Take a Ref to the HTMLPlugInElement to keep it alive while invoking HTMLPlugInElement::swapRendererTimerFired()
+
+ * html/HTMLPlugInElement.cpp:
+ (WebCore::HTMLPlugInElement::swapRendererTimerFired):
+
2021-03-27 Ryosuke Niwa <rn...@webkit.org>
Don't add Frame as an opaque root of DOMWindow
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLPlugInElement.cpp (281302 => 281303)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLPlugInElement.cpp 2021-08-20 09:18:31 UTC (rev 281302)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/html/HTMLPlugInElement.cpp 2021-08-20 09:19:45 UTC (rev 281303)
@@ -272,6 +272,7 @@
// Create a shadow root, which will trigger the code to add a snapshot container
// and reattach, thus making a new Renderer.
+ Ref<HTMLPlugInElement> protectedThis(*this);
ensureUserAgentShadowRoot();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
