Diff
Modified: trunk/Source/WTF/ChangeLog (282136 => 282137)
--- trunk/Source/WTF/ChangeLog 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WTF/ChangeLog 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1,3 +1,13 @@
+2021-09-08 Jean-Yves Avenard <j...@apple.com>
+
+ Safari TP 131 audio canPlayType() reports false negatives
+ https://bugs.webkit.org/show_bug.cgi?id=229799
+ rdar://problem/82776747
+
+ Reviewed by Youenn Fablet.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml: Remove preference.
+
2021-09-07 Sihui Liu <sihui_...@apple.com>
Add basic support for Storage API
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (282136 => 282137)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1366,18 +1366,6 @@
WebKit:
default: WebKit::defaultWebMParserEnabled()
-WebMWebAudioEnabled:
- type: bool
- webcoreBinding: RuntimeEnabledFeatures
- humanReadableName: "WebM Web Audio"
- humanReadableDescription: "Enable WebM Web Audio"
- condition: ENABLE(MEDIA_SOURCE)
- defaultValue:
- WebKitLegacy:
- default: WebKit::defaultWebMWebAudioEnabled()
- WebKit:
- default: WebKit::defaultWebMWebAudioEnabled()
-
# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
WebRTCH264LowLatencyEncoderEnabled:
type: bool
Modified: trunk/Source/WebCore/ChangeLog (282136 => 282137)
--- trunk/Source/WebCore/ChangeLog 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/ChangeLog 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1,3 +1,19 @@
+2021-09-08 Jean-Yves Avenard <j...@apple.com>
+
+ Safari TP 131 audio canPlayType() reports false negatives
+ https://bugs.webkit.org/show_bug.cgi?id=229799
+ rdar://problem/82776747
+
+ Reviewed by Youenn Fablet.
+
+ webaudio now supports the same webm content as the video and audio element,
+ making this workaround no longer necessary.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::canPlayType const): Remove work around
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::webMParserEnabled const): Remove now unused method.
+
2021-09-08 Kimmo Kinnunen <kkinnu...@apple.com>
webgl/2.0.y/deqp/functional/gles3/negativeshaderapi.html fails on Metal
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (282136 => 282137)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1061,15 +1061,6 @@
return m_networkState;
}
-static inline bool webMWebAudioEnabled()
-{
-#if ENABLE(MEDIA_SOURCE)
- return RuntimeEnabledFeatures::sharedFeatures().webMWebAudioEnabled();
-#else
- return false;
-#endif
-}
-
String HTMLMediaElement::canPlayType(const String& mimeType) const
{
MediaEngineSupportParameters parameters;
@@ -1079,14 +1070,6 @@
MediaPlayer::SupportsType support = MediaPlayer::supportsType(parameters);
String canPlay;
-#if PLATFORM(COCOA)
- // Temporarily work around bug 226922. For now claim that the opus and vorbis codecs aren't supported
- // so that sites relying on this test to determine if webaudio use of opus or vorbis won't error.
- auto codecs = contentType.codecs();
- if (support == MediaPlayer::SupportsType::IsSupported && ((codecs.contains("opus") || codecs.contains("vorbis")) && !webMWebAudioEnabled()))
- support = MediaPlayer::SupportsType::IsNotSupported;
-#endif
-
// 4.8.10.3
switch (support)
{
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (282136 => 282137)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2021-09-08 11:01:18 UTC (rev 282137)
@@ -235,8 +235,6 @@
#if ENABLE(MEDIA_SOURCE)
void setWebMParserEnabled(bool isEnabled) { m_webMParserEnabled = isEnabled; }
bool webMParserEnabled() const { return m_webMParserEnabled; }
- void setWebMWebAudioEnabled(bool isEnabled) { m_webMWebAudioEnabled = isEnabled; }
- bool webMWebAudioEnabled() const { return m_webMWebAudioEnabled; }
#endif
#if HAVE(CELESTIAL)
@@ -377,7 +375,6 @@
#if ENABLE(MEDIA_SOURCE)
bool m_webMParserEnabled { false };
- bool m_webMWebAudioEnabled { false };
#endif
#if HAVE(CELESTIAL)
Modified: trunk/Source/WebKit/ChangeLog (282136 => 282137)
--- trunk/Source/WebKit/ChangeLog 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/ChangeLog 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1,3 +1,14 @@
+2021-09-08 Jean-Yves Avenard <j...@apple.com>
+
+ Safari TP 131 audio canPlayType() reports false negatives
+ https://bugs.webkit.org/show_bug.cgi?id=229799
+ rdar://problem/82776747
+
+ Reviewed by Youenn Fablet.
+
+ * Shared/WebPreferencesDefaultValues.cpp:
+ * Shared/WebPreferencesDefaultValues.h: Remove no longer used method.
+
2021-09-07 Sihui Liu <sihui_...@apple.com>
Add basic support for Storage API
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (282136 => 282137)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-09-08 11:01:18 UTC (rev 282137)
@@ -314,11 +314,6 @@
return isFeatureFlagEnabled("webm_parser", true);
}
-bool defaultWebMWebAudioEnabled()
-{
- return isFeatureFlagEnabled("webm_webaudio", false);
-}
-
#endif // ENABLE(MEDIA_SOURCE)
#if ENABLE(MEDIA_SESSION_COORDINATOR)
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (282136 => 282137)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2021-09-08 11:01:18 UTC (rev 282137)
@@ -103,7 +103,6 @@
#if ENABLE(MEDIA_SOURCE)
bool defaultWebMParserEnabled();
-bool defaultWebMWebAudioEnabled();
#endif
#if ENABLE(MEDIA_SESSION_COORDINATOR)
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (282136 => 282137)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-09-08 11:01:18 UTC (rev 282137)
@@ -1,3 +1,14 @@
+2021-09-08 Jean-Yves Avenard <j...@apple.com>
+
+ Safari TP 131 audio canPlayType() reports false negatives
+ https://bugs.webkit.org/show_bug.cgi?id=229799
+ rdar://problem/82776747
+
+ Reviewed by Youenn Fablet.
+
+ * WebView/WebPreferencesDefaultValues.h:
+ * WebView/WebPreferencesDefaultValues.mm: Remove no longer used method.
+
2021-09-07 Sihui Liu <sihui_...@apple.com>
Add basic support for Storage API
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (282136 => 282137)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2021-09-08 11:01:18 UTC (rev 282137)
@@ -83,7 +83,6 @@
#if ENABLE(MEDIA_SOURCE)
bool defaultWebMParserEnabled();
-bool defaultWebMWebAudioEnabled();
#endif
#if ENABLE(VP9)
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (282136 => 282137)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2021-09-08 10:21:20 UTC (rev 282136)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2021-09-08 11:01:18 UTC (rev 282137)
@@ -282,11 +282,6 @@
return isFeatureFlagEnabled("webm_parser", true);
}
-bool defaultWebMWebAudioEnabled()
-{
- return isFeatureFlagEnabled("webm_webaudio", false);
-}
-
#endif // ENABLE(MEDIA_SOURCE)
#if ENABLE(VP9)
