Title: [282151] trunk/LayoutTests
- Revision
- 282151
- Author
- you...@apple.com
- Date
- 2021-09-08 10:20:44 -0700 (Wed, 08 Sep 2021)
Log Message
Make webrtc/datachannel/getStats-no-prflx-remote-candidate.html provide more meaningful errors
https://bugs.webkit.org/show_bug.cgi?id=230003
Reviewed by Eric Carlson.
* webrtc/datachannel/getStats-no-prflx-remote-candidate.html:
The test is timing out flakily, add some errors to know where it is timing out.
Make sure to call send once the local channel is opened.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (282150 => 282151)
--- trunk/LayoutTests/ChangeLog 2021-09-08 17:11:09 UTC (rev 282150)
+++ trunk/LayoutTests/ChangeLog 2021-09-08 17:20:44 UTC (rev 282151)
@@ -1,5 +1,16 @@
2021-09-08 Youenn Fablet <you...@apple.com>
+ Make webrtc/datachannel/getStats-no-prflx-remote-candidate.html provide more meaningful errors
+ https://bugs.webkit.org/show_bug.cgi?id=230003
+
+ Reviewed by Eric Carlson.
+
+ * webrtc/datachannel/getStats-no-prflx-remote-candidate.html:
+ The test is timing out flakily, add some errors to know where it is timing out.
+ Make sure to call send once the local channel is opened.
+
+2021-09-08 Youenn Fablet <you...@apple.com>
+
webrtc/ephemeral-certificates-and-cnames.html needs to close its connections between two tests
https://bugs.webkit.org/show_bug.cgi?id=229931
Modified: trunk/LayoutTests/webrtc/datachannel/getStats-no-prflx-remote-candidate.html (282150 => 282151)
--- trunk/LayoutTests/webrtc/datachannel/getStats-no-prflx-remote-candidate.html 2021-09-08 17:11:09 UTC (rev 282150)
+++ trunk/LayoutTests/webrtc/datachannel/getStats-no-prflx-remote-candidate.html 2021-09-08 17:20:44 UTC (rev 282151)
@@ -34,6 +34,10 @@
});
const localDataChannel = localPc.createDataChannel('test');
+ const localDataChannelPromise = new Promise((resolve, reject) => {
+ localDataChannel._onopen_ = resolve;
+ setTimeout(() => reject('localDataChannelPromise'), 5000);
+ });
localPc.addEventListener('icecandidate', event => {
remotePc.addIceCandidate(event.candidate);
@@ -43,11 +47,17 @@
const remoteDataChannel = await promiseDataChannel;
assert_true(!!remoteDataChannel, "remoteDataChannel is defined");
- await new Promise(resolve => {
+
+ const remoteDataChannelPromise = new Promise((resolve, reject) => {
remoteDataChannel._onmessage_ = resolve;
- localDataChannel.send("test");
+ setTimeout(() => reject('remoteDataChannelPromise'), 5000);
});
+ await localDataChannelPromise;
+ localDataChannel.send("test");
+
+ await remoteDataChannelPromise;
+
const remoteCandidateStats = getRequiredStats(await localPc.getStats(), "remote-candidate");
assert_equals(remoteCandidateStats.address, undefined, "address should remain undefined");
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
