Title: [282164] trunk/Tools
Revision
282164
Author
hironori.fu...@sony.com
Date
2021-09-08 12:52:29 -0700 (Wed, 08 Sep 2021)

Log Message

[Win][DumpRenderTree] ASSERTION FAILED: openWindows().size() == 1 in runTest
https://bugs.webkit.org/show_bug.cgi?id=229932

Reviewed by Chris Dumez.

runTest() called DestroyWindow while iterating 'openWindows'.
However, DestroyWindow dispatches WM_DESTROY that removes the item
from 'openWindows'.

* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Copy the vector to iterate.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (282163 => 282164)


--- trunk/Tools/ChangeLog	2021-09-08 19:47:28 UTC (rev 282163)
+++ trunk/Tools/ChangeLog	2021-09-08 19:52:29 UTC (rev 282164)
@@ -1,3 +1,17 @@
+2021-09-08  Fujii Hironori  <hironori.fu...@sony.com>
+
+        [Win][DumpRenderTree] ASSERTION FAILED: openWindows().size() == 1 in runTest
+        https://bugs.webkit.org/show_bug.cgi?id=229932
+
+        Reviewed by Chris Dumez.
+
+        runTest() called DestroyWindow while iterating 'openWindows'.
+        However, DestroyWindow dispatches WM_DESTROY that removes the item
+        from 'openWindows'.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (runTest): Copy the vector to iterate.
+
 2021-09-08  Simon Fraser  <simon.fra...@apple.com>
 
         Add a temporarily prefixed property for mask-mode, aliased to -webkit-mask-source-type

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (282163 => 282164)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2021-09-08 19:47:28 UTC (rev 282163)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2021-09-08 19:52:29 UTC (rev 282164)
@@ -1328,7 +1328,7 @@
     ::gTestRunner->closeWebInspector();
 
 
-    for (HWND window : openWindows()) {
+    for (HWND window : Vector(openWindows())) {
         // Don't try to close the main window
         if (window == hostWindow)
             continue;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to