Title: [282906] branches/safari-612-branch/Source/_javascript_Core
Revision
282906
Author
repst...@apple.com
Date
2021-09-22 21:28:54 -0700 (Wed, 22 Sep 2021)

Log Message

Cherry-pick r281319. rdar://problem/83430082

    Reduce StructureID entropy bits to 5 to make room for more StructureIDs.
    https://bugs.webkit.org/show_bug.cgi?id=229326
    rdar://60141624

    Reviewed by Yusuke Suzuki.

    * runtime/StructureIDTable.h:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-612-branch/Source/_javascript_Core/ChangeLog (282905 => 282906)


--- branches/safari-612-branch/Source/_javascript_Core/ChangeLog	2021-09-23 04:08:29 UTC (rev 282905)
+++ branches/safari-612-branch/Source/_javascript_Core/ChangeLog	2021-09-23 04:28:54 UTC (rev 282906)
@@ -1,3 +1,28 @@
+2021-09-22  Alan Coon  <alanc...@apple.com>
+
+        Cherry-pick r281319. rdar://problem/83430082
+
+    Reduce StructureID entropy bits to 5 to make room for more StructureIDs.
+    https://bugs.webkit.org/show_bug.cgi?id=229326
+    rdar://60141624
+    
+    Reviewed by Yusuke Suzuki.
+    
+    * runtime/StructureIDTable.h:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-08-20  Mark Lam  <mark....@apple.com>
+
+            Reduce StructureID entropy bits to 5 to make room for more StructureIDs.
+            https://bugs.webkit.org/show_bug.cgi?id=229326
+            rdar://60141624
+
+            Reviewed by Yusuke Suzuki.
+
+            * runtime/StructureIDTable.h:
+
 2021-09-16  Russell Epstein  <repst...@apple.com>
 
         Cherry-pick r282239. rdar://problem/83183776

Modified: branches/safari-612-branch/Source/_javascript_Core/runtime/StructureIDTable.h (282905 => 282906)


--- branches/safari-612-branch/Source/_javascript_Core/runtime/StructureIDTable.h	2021-09-23 04:08:29 UTC (rev 282905)
+++ branches/safari-612-branch/Source/_javascript_Core/runtime/StructureIDTable.h	2021-09-23 04:28:54 UTC (rev 282906)
@@ -140,7 +140,7 @@
     // 1. StructureID is encoded as:
     //
     //    ----------------------------------------------------------------
-    //    | 1 Nuke Bit | 24 StructureIDTable index bits | 7 entropy bits |
+    //    | 1 Nuke Bit | 26 StructureIDTable index bits | 5 entropy bits |
     //    ----------------------------------------------------------------
     //
     //    The entropy bits are chosen at random and assigned when a StructureID
@@ -149,15 +149,15 @@
     // 2. For each StructureID, the StructureIDTable stores encodedStructureBits
     //    which are encoded from the structure pointer as such:
     //
-    //    -----------------------------------------------------------------
-    //    | 9 low index bits | 7 entropy bits | 48 structure pointer bits |
-    //    -----------------------------------------------------------------
+    //    ------------------------------------------------------------------
+    //    | 11 low index bits | 5 entropy bits | 48 structure pointer bits |
+    //    ------------------------------------------------------------------
     //
-    //    The entropy bits here are the same 7 bits used in the encoding of the
+    //    The entropy bits here are the same 5 bits used in the encoding of the
     //    StructureID for this structure entry in the StructureIDTable.
 
     static constexpr uint32_t s_numberOfNukeBits = 1;
-    static constexpr uint32_t s_numberOfEntropyBits = 7;
+    static constexpr uint32_t s_numberOfEntropyBits = 5;
     static constexpr uint32_t s_entropyBitsShiftForStructurePointer = (sizeof(EncodedStructureBits) * 8) - 16;
 
     static constexpr uint32_t s_maximumNumberOfStructures = 1 << (32 - s_numberOfEntropyBits - s_numberOfNukeBits);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to