- Revision
- 283342
- Author
- wilan...@apple.com
- Date
- 2021-09-30 15:42:17 -0700 (Thu, 30 Sep 2021)
Log Message
PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
https://bugs.webkit.org/show_bug.cgi?id=230914
<rdar://problem/83639923>
Reviewed by Brent Fulgham.
This patch changes Private Click Measurement's WebIDL attributes from
all lowercase to camelcase to match the spec and align with the
Attribution Reporting API proposal.
References
- Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
- Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
Source/WebCore:
Existing tests updated.
* html/HTMLAnchorElement.idl:
LayoutTests:
* http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
* http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
* http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (283341 => 283342)
--- trunk/LayoutTests/ChangeLog 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/ChangeLog 2021-09-30 22:42:17 UTC (rev 283342)
@@ -1,3 +1,23 @@
+2021-09-30 John Wilander <wilan...@apple.com>
+
+ PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+ https://bugs.webkit.org/show_bug.cgi?id=230914
+ <rdar://problem/83639923>
+
+ Reviewed by Brent Fulgham.
+
+ This patch changes Private Click Measurement's WebIDL attributes from
+ all lowercase to camelcase to match the spec and align with the
+ Attribution Reporting API proposal.
+
+ References
+ - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+ - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt:
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html:
+ * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html:
+
2021-09-30 Ziran Sun <z...@igalia.com>
[css-grid] Transfer sizes from the aspect-ratio while resolving min-length for auto repetitions
Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt (283341 => 283342)
--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect-expected.txt 2021-09-30 22:42:17 UTC (rev 283342)
@@ -1,10 +1,10 @@
-Test for the new private click measurement attributes on anchor tags.
+Test for private click measurement attributes on anchor tags.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS anchorTag.attributionsourceid is 40
-PASS anchorTag.attributiondestination is "https://destination.example"
+PASS anchorTag.attributionSourceId is 40
+PASS anchorTag.attributionDestination is "https://destination.example"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html (283341 => 283342)
--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-reflect.html 2021-09-30 22:42:17 UTC (rev 283342)
@@ -7,11 +7,11 @@
<body>
<a id="testTag" href="" attributionsourceid=40 attributiondestination="https://destination.example"></a>
<script>
- description("Test for the new private click measurement attributes on anchor tags.");
+ description("Test for private click measurement attributes on anchor tags.");
const anchorTag = document.getElementById("testTag");
- shouldBeEqualToNumber("anchorTag.attributionsourceid", 40);
- shouldBeEqualToString("anchorTag.attributiondestination", "https://destination.example");
+ shouldBeEqualToNumber("anchorTag.attributionSourceId", 40);
+ shouldBeEqualToString("anchorTag.attributionDestination", "https://destination.example");
</script>
</body>
</html>
Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html (283341 => 283342)
--- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html 2021-09-30 22:42:17 UTC (rev 283342)
@@ -25,9 +25,9 @@
anchorElement.id = elementID;
anchorElement.classList.add("wide-link");
if (sourceID !== null)
- anchorElement.attributionsourceid = sourceID;
+ anchorElement.attributionSourceId = sourceID;
if (destination !== null)
- anchorElement.attributiondestination = destination;
+ anchorElement.attributionDestination = destination;
anchorElement.href = ""
anchorElement.innerText = "Link" + currentTest;
return anchorElement;
Modified: trunk/Source/WebCore/ChangeLog (283341 => 283342)
--- trunk/Source/WebCore/ChangeLog 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/Source/WebCore/ChangeLog 2021-09-30 22:42:17 UTC (rev 283342)
@@ -1,3 +1,23 @@
+2021-09-30 John Wilander <wilan...@apple.com>
+
+ PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
+ https://bugs.webkit.org/show_bug.cgi?id=230914
+ <rdar://problem/83639923>
+
+ Reviewed by Brent Fulgham.
+
+ This patch changes Private Click Measurement's WebIDL attributes from
+ all lowercase to camelcase to match the spec and align with the
+ Attribution Reporting API proposal.
+
+ References
+ - Private Click Measurement proposal: https://privacycg.github.io/private-click-measurement/#linkformat
+ - Attribution Reporting API proposal: https://wicg.github.io/conversion-measurement-api/#monkeypatch-anchor
+
+ Existing tests updated.
+
+ * html/HTMLAnchorElement.idl:
+
2021-09-30 Rob Buis <rb...@igalia.com>
Move canCompositeClipPath to RenderLayer
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.idl (283341 => 283342)
--- trunk/Source/WebCore/html/HTMLAnchorElement.idl 2021-09-30 22:34:21 UTC (rev 283341)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.idl 2021-09-30 22:42:17 UTC (rev 283342)
@@ -21,9 +21,9 @@
[
Exposed=Window
] interface HTMLAnchorElement : HTMLElement {
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionsourceid;
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributiondestination;
- [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionsourcenonce;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute unsigned long attributionSourceId;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurement, Reflect] attribute DOMString attributionDestination;
+ [CEReactions=NotNeeded, EnabledBySetting=PrivateClickMeasurementFraudPrevention, Reflect] attribute DOMString attributionSourceNonce;
[CEReactions=NotNeeded, Reflect] attribute DOMString charset;
[CEReactions=NotNeeded, Reflect] attribute DOMString coords;
[CEReactions=NotNeeded, Conditional=DOWNLOAD_ATTRIBUTE, EnabledBySetting=DownloadAttribute, Reflect] attribute DOMString download;
