Title: [284699] trunk/Source/_javascript_Core
- Revision
- 284699
- Author
- sbar...@apple.com
- Date
- 2021-10-22 11:23:09 -0700 (Fri, 22 Oct 2021)
Log Message
canDoFastSpread should also check that the Structure is from the global object we're watching
https://bugs.webkit.org/show_bug.cgi?id=231976
<rdar://84340372>
Reviewed by Keith Miller.
Just reorder the checks for clarity.
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::canDoFastSpread):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (284698 => 284699)
--- trunk/Source/_javascript_Core/ChangeLog 2021-10-22 18:22:22 UTC (rev 284698)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-10-22 18:23:09 UTC (rev 284699)
@@ -1,3 +1,16 @@
+2021-10-22 Saam Barati <sbar...@apple.com>
+
+ canDoFastSpread should also check that the Structure is from the global object we're watching
+ https://bugs.webkit.org/show_bug.cgi?id=231976
+ <rdar://84340372>
+
+ Reviewed by Keith Miller.
+
+ Just reorder the checks for clarity.
+
+ * dfg/DFGGraph.cpp:
+ (JSC::DFG::Graph::canDoFastSpread):
+
2021-10-22 Robin Morisset <rmoris...@apple.com>
--reportBytecodeCompileTimes=1 should correctly report the bytecode size
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (284698 => 284699)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2021-10-22 18:22:22 UTC (rev 284698)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2021-10-22 18:23:09 UTC (rev 284699)
@@ -1847,8 +1847,8 @@
ArrayPrototype* arrayPrototype = globalObject->arrayPrototype();
bool allGood = true;
value.m_structure.forEach([&] (RegisteredStructure structure) {
- allGood &= structure->hasMonoProto()
- && structure->globalObject() == globalObject
+ allGood &= structure->globalObject() == globalObject
+ && structure->hasMonoProto()
&& structure->storedPrototype() == arrayPrototype
&& !structure->isDictionary()
&& structure->getConcurrently(m_vm.propertyNames->iteratorSymbol.impl()) == invalidOffset
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
