Title: [284974] releases/WebKitGTK/webkit-2.34/Source/WebCore
- Revision
- 284974
- Author
- ape...@igalia.com
- Date
- 2021-10-28 03:02:45 -0700 (Thu, 28 Oct 2021)
Log Message
Merge r281867 - REGRESSION(r280928) The smooth keyboard scrolling is unconditionally enabled for PageUp and PageDown keys
https://bugs.webkit.org/show_bug.cgi?id=229733
Reviewed by Tim Horton.
Even though WinCairo port doesn't enable
EventHandlerDrivenSmoothKeyboardScrollingEnabled yet, it had been
enabled only for PageUp and PageDown keys since r280928. Other
keys (Space and Arrow keys) don't trigger the smooth scrolling.
r280928 changed to call startKeyboardScrolling for PageUp and
PageDown keys, but it didn't check the setting.
* page/EventHandler.cpp:
(WebCore::EventHandler::startKeyboardScrolling):
(WebCore::EventHandler::defaultKeyboardEventHandler):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (284973 => 284974)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2021-10-28 08:59:03 UTC (rev 284973)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2021-10-28 10:02:45 UTC (rev 284974)
@@ -1,3 +1,22 @@
+2021-09-01 Fujii Hironori <hironori.fu...@sony.com>
+
+ REGRESSION(r280928) The smooth keyboard scrolling is unconditionally enabled for PageUp and PageDown keys
+ https://bugs.webkit.org/show_bug.cgi?id=229733
+
+ Reviewed by Tim Horton.
+
+ Even though WinCairo port doesn't enable
+ EventHandlerDrivenSmoothKeyboardScrollingEnabled yet, it had been
+ enabled only for PageUp and PageDown keys since r280928. Other
+ keys (Space and Arrow keys) don't trigger the smooth scrolling.
+
+ r280928 changed to call startKeyboardScrolling for PageUp and
+ PageDown keys, but it didn't check the setting.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::startKeyboardScrolling):
+ (WebCore::EventHandler::defaultKeyboardEventHandler):
+
2021-10-26 Adrian Perez de Castro <ape...@igalia.com>
Multiple build issues with ENABLE_VIDEO=OFF
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp (284973 => 284974)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp 2021-10-28 08:59:03 UTC (rev 284973)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp 2021-10-28 10:02:45 UTC (rev 284974)
@@ -4288,6 +4288,9 @@
bool EventHandler::startKeyboardScrolling(KeyboardEvent& event)
{
+ if (!m_frame.settings().eventHandlerDrivenSmoothKeyboardScrollingEnabled())
+ return false;
+
Ref protectedFrame = m_frame;
FrameView* view = m_frame.view();
@@ -4304,8 +4307,7 @@
ASSERT(event.type() == eventNames().keydownEvent);
if (!isSpatialNavigationEnabled(&m_frame)) {
- if (m_frame.settings().eventHandlerDrivenSmoothKeyboardScrollingEnabled())
- startKeyboardScrolling(event);
+ startKeyboardScrolling(event);
return;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
