Title: [284986] trunk/Source/WebInspectorUI
- Revision
- 284986
- Author
- rcali...@apple.com
- Date
- 2021-10-28 09:28:03 -0700 (Thu, 28 Oct 2021)
Log Message
Web Inspector: Audit: testForLinkLabels Accessibility audit should ignore anchors if aria-hidden
https://bugs.webkit.org/show_bug.cgi?id=231038
<rdar://problem/83783868>
Update `testForLinkLabels` accessibility audit test to exclude hidden links.
See `AccessibilityObject->isHidden()`
Reviewed by BJ Burg.
* UserInterface/NonMinified/DefaultAudits.js:
(WI.DefaultAudits.testForLinkLabels):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (284985 => 284986)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-10-28 16:21:48 UTC (rev 284985)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-10-28 16:28:03 UTC (rev 284986)
@@ -1,3 +1,17 @@
+2021-10-28 Razvan Caliman <rcali...@apple.com>
+
+ Web Inspector: Audit: testForLinkLabels Accessibility audit should ignore anchors if aria-hidden
+ https://bugs.webkit.org/show_bug.cgi?id=231038
+ <rdar://problem/83783868>
+
+ Update `testForLinkLabels` accessibility audit test to exclude hidden links.
+ See `AccessibilityObject->isHidden()`
+
+ Reviewed by BJ Burg.
+
+ * UserInterface/NonMinified/DefaultAudits.js:
+ (WI.DefaultAudits.testForLinkLabels):
+
2021-10-27 BJ Burg <bb...@apple.com>
Web Inspector: extension iframes leak when disabling an extension
Modified: trunk/Source/WebInspectorUI/UserInterface/NonMinified/DefaultAudits.js (284985 => 284986)
--- trunk/Source/WebInspectorUI/UserInterface/NonMinified/DefaultAudits.js 2021-10-28 16:21:48 UTC (rev 284985)
+++ trunk/Source/WebInspectorUI/UserInterface/NonMinified/DefaultAudits.js 2021-10-28 16:28:03 UTC (rev 284986)
@@ -238,7 +238,10 @@
WI.DefaultAudits.testForLinkLabels = function() {
let links = WebInspectorAudit.Accessibility.getElementsByComputedRole("link");
- let domNodes = links.filter((link) => !WebInspectorAudit.Accessibility.getComputedProperties(link).label);
+ let domNodes = links.filter((link) => {
+ let properties = WebInspectorAudit.Accessibility.getComputedProperties(link);
+ return !properties.label && !properties.hidden;
+ });
return {level: domNodes.length ? "fail" : "pass", domNodes, domAttributes: ["aria-label", "aria-labelledby", "title"]};
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
