Title: [287104] trunk/Source/WebCore
- Revision
- 287104
- Author
- tyle...@apple.com
- Date
- 2021-12-15 13:26:53 -0800 (Wed, 15 Dec 2021)
Log Message
AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place
https://bugs.webkit.org/show_bug.cgi?id=234334
Reviewed by Chris Fleizach.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
Move comment about accessibilityShouldUseUniqueId next to its
defintion rather than its current location next to
accessibilityIsIgnored.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287103 => 287104)
--- trunk/Source/WebCore/ChangeLog 2021-12-15 21:24:41 UTC (rev 287103)
+++ trunk/Source/WebCore/ChangeLog 2021-12-15 21:26:53 UTC (rev 287104)
@@ -1,3 +1,15 @@
+2021-12-15 Tyler Wilcock <tyle...@apple.com>
+
+ AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place
+ https://bugs.webkit.org/show_bug.cgi?id=234334
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ Move comment about accessibilityShouldUseUniqueId next to its
+ defintion rather than its current location next to
+ accessibilityIsIgnored.
+
2021-12-15 Alexey Shvayka <ashva...@apple.com>
[WebIDL] Remove the now-unused [DocumentEventHandler] extended attribute
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (287103 => 287104)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-12-15 21:24:41 UTC (rev 287103)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2021-12-15 21:26:53 UTC (rev 287104)
@@ -3009,15 +3009,6 @@
return NO;
}
-// accessibilityShouldUseUniqueId is an AppKit method we override so that
-// objects will be given a unique ID, and therefore allow AppKit to know when they
-// become obsolete (e.g. when the user navigates to a new web page, making this one
-// unrendered but not deallocated because it is in the back/forward cache).
-// It is important to call NSAccessibilityUnregisterUniqueIdForUIElement in the
-// appropriate place (e.g. dealloc) to remove these non-retained references from
-// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
-//
-// Registering an object is also required for observing notifications. Only registered objects can be observed.
ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
- (BOOL)accessibilityIsIgnored
ALLOW_DEPRECATED_IMPLEMENTATIONS_END
@@ -4331,6 +4322,15 @@
return YES;
}
+// accessibilityShouldUseUniqueId is an AppKit method we override so that
+// objects will be given a unique ID, and therefore allow AppKit to know when they
+// become obsolete (e.g. when the user navigates to a new web page, making this one
+// unrendered but not deallocated because it is in the back/forward cache).
+// It is important to call NSAccessibilityUnregisterUniqueIdForUIElement in the
+// appropriate place (e.g. dealloc) to remove these non-retained references from
+// AppKit's id mapping tables. We do this in detach by calling unregisterUniqueIdForUIElement.
+//
+// Registering an object is also required for observing notifications. Only registered objects can be observed.
- (BOOL)accessibilityShouldUseUniqueId
{
// All AX object wrappers should use unique ID's because it's faster within AppKit to look them up.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
