Title: [287272] trunk/Source/WebKitLegacy/win
- Revision
- 287272
- Author
- hironori.fu...@sony.com
- Date
- 2021-12-20 12:19:38 -0800 (Mon, 20 Dec 2021)
Log Message
[Win] MSVC reports "COMPropertyBag.h(233): error C2385: ambiguous access of 'IUnknown'" with /std:c++20
https://bugs.webkit.org/show_bug.cgi?id=234498
Reviewed by Don Olmstead.
> Source\WebKitLegacy\win\COMPropertyBag.h(233): error C2385: ambiguous access of 'IUnknown'
This problem has been reported in the following ticket, and it has a workaround.
<https://developercommunity.visualstudio.com/t/error-c2385-ambiguous-access-of-iunknown-referring/230955>
* COMPropertyBag.h:
(HashType>::LoadObject): Added the global namespace prefix '::' to
IUnknown for the workaround.
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/win/COMPropertyBag.h (287271 => 287272)
--- trunk/Source/WebKitLegacy/win/COMPropertyBag.h 2021-12-20 20:17:09 UTC (rev 287271)
+++ trunk/Source/WebKitLegacy/win/COMPropertyBag.h 2021-12-20 20:19:38 UTC (rev 287272)
@@ -230,7 +230,7 @@
}
template<typename ValueType, typename KeyType, typename HashType>
-HRESULT STDMETHODCALLTYPE COMPropertyBag<ValueType, KeyType, HashType>::LoadObject(_In_ LPCOLESTR pstrName, DWORD dwHint, _In_opt_ IUnknown*, _In_opt_ IErrorLog*)
+HRESULT STDMETHODCALLTYPE COMPropertyBag<ValueType, KeyType, HashType>::LoadObject(_In_ LPCOLESTR pstrName, DWORD dwHint, _In_opt_ ::IUnknown*, _In_opt_ IErrorLog*)
{
return E_NOTIMPL;
}
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (287271 => 287272)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2021-12-20 20:17:09 UTC (rev 287271)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2021-12-20 20:19:38 UTC (rev 287272)
@@ -1,5 +1,21 @@
2021-12-20 Fujii Hironori <hironori.fu...@sony.com>
+ [Win] MSVC reports "COMPropertyBag.h(233): error C2385: ambiguous access of 'IUnknown'" with /std:c++20
+ https://bugs.webkit.org/show_bug.cgi?id=234498
+
+ Reviewed by Don Olmstead.
+
+ > Source\WebKitLegacy\win\COMPropertyBag.h(233): error C2385: ambiguous access of 'IUnknown'
+
+ This problem has been reported in the following ticket, and it has a workaround.
+ <https://developercommunity.visualstudio.com/t/error-c2385-ambiguous-access-of-iunknown-referring/230955>
+
+ * COMPropertyBag.h:
+ (HashType>::LoadObject): Added the global namespace prefix '::' to
+ IUnknown for the workaround.
+
+2021-12-20 Fujii Hironori <hironori.fu...@sony.com>
+
[Win] MSVC reports "COMVariantSetter.h(133): error C2760: syntax error: unexpected token 'identifier', expected ';'" with /std:c++20
https://bugs.webkit.org/show_bug.cgi?id=234501
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
